MINIFICPP-1347 Do not override MergeContent output attributes#888
Closed
lordgamez wants to merge 3 commits intoapache:mainfrom
Closed
MINIFICPP-1347 Do not override MergeContent output attributes#888lordgamez wants to merge 3 commits intoapache:mainfrom
lordgamez wants to merge 3 commits intoapache:mainfrom
Conversation
This commit handles the case when flowfiles processed by MergeContent could have common attributes, with the same value (like mime type) which after the attribute merge would override the individually set output attribute.
hunyadi-dev
reviewed
Sep 1, 2020
hunyadi-dev
approved these changes
Sep 1, 2020
lordgamez
changed the title
arpadboda
reviewed
Sep 3, 2020
Contributor
arpadboda
left a comment
arpadboda
left a comment
There was a problem hiding this comment.
The fix itself looks good, but config issues should be handled in onschedule.
You can set up a member function ptr there to simply call it when flowfiles are actually processed.
| KeepAllUniqueAttributesMerger(bin->getFlowFile()).mergeAttributes(session, merge_flow); | ||
| else { | ||
| logger_->log_error("Attribute strategy not supported %s", attributeStrategy_); | ||
| throw minifi::Exception(ExceptionType::PROCESSOR_EXCEPTION, "Invalid attribute strategy: " + attributeStrategy_); |
Contributor
There was a problem hiding this comment.
I think this error should be handled in onSchedule.
This function (processbin) is called runtime, config issues shouldn't be handled here.
arpadboda
pushed a commit
that referenced
this pull request
Sep 14, 2020
This commit handles the case when flowfiles processed by MergeContent could have common attributes, with the same value (like mime type) which after the attribute merge would override the individually set output attribute. Signed-off-by: Arpad Boda <aboda@apache.org> This closes #888
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit handles the case when flowfiles processed by MergeContent
could have common attributes, with the same value (like mime type)
which after the attribute merge would override the individually set
output attribute.
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
Has your PR been rebased against the latest commit within the target branch (typically main)?
Is your initial contribution a single, squashed commit?
For code changes:
For documentation related changes:
Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.