Skip to content

MINIFICPP-1368 - Increment version number on main#905

Closed
arpadboda wants to merge 1 commit into
apache:mainfrom
arpadboda:MINIFICPP-1368
Closed

MINIFICPP-1368 - Increment version number on main#905
arpadboda wants to merge 1 commit into
apache:mainfrom
arpadboda:MINIFICPP-1368

Conversation

@arpadboda
Copy link
Copy Markdown
Contributor

Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message?

  • Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically main)?

  • Is your initial contribution a single, squashed commit?

For code changes:

  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE file?
  • If applicable, have you updated the NOTICE file?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible.

@szaszm
Copy link
Copy Markdown
Member

szaszm commented Sep 14, 2020

libminifi/CMakeLists.txt needs to be changed, too

@arpadboda
Copy link
Copy Markdown
Contributor Author

libminifi/CMakeLists.txt needs to be changed, too

Done

@szaszm szaszm closed this in 41a1094 Sep 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants