MINIFICPP-1391 Upgrade XCode version and replace usages of set-env#925
Closed
fgerlits wants to merge 5 commits intoapache:mainfrom
Closed
MINIFICPP-1391 Upgrade XCode version and replace usages of set-env#925fgerlits wants to merge 5 commits intoapache:mainfrom
fgerlits wants to merge 5 commits intoapache:mainfrom
Conversation
lordgamez
approved these changes
Oct 14, 2020
arpadboda
reviewed
Oct 14, 2020
set-env has been deprecated and triggers a warning; see https://github.blog/changelog/2020-10-01-github-actions-deprecating-set-env-and-add-path-commands/
This environment setting doesn't do anything, and it gives the false appearance as if the Pcap extension was enabled (it isn't). As the Pcap extension is not in a good shape, I have left it disabled. ENABLE_LUA_SCRIPTING seems to work (at least it compiles), so I enabled it in the jobs where the intention was to enable it.
fgerlits
force-pushed
the
MINIFICPP-1391-Upgrade-XCode-version-in-CI-job
branch
from
23b7e39 to
35a3327
Compare
hunyadi-dev
approved these changes
Oct 19, 2020
arpadboda
reviewed
Oct 19, 2020
arpadboda
approved these changes
Oct 19, 2020
szaszm
approved these changes
Oct 19, 2020
Contributor
Author
Cmake doesn't look at the value of So this line made it appear as if we were compiling with |
Member
|
I've deleted this question because I realized that you've already answered it in the description. Thanks for the clarification. |
hunyadi-dev
pushed a commit
to hunyadi-dev/nifi-minifi-cpp
that referenced
this pull request
Jan 4, 2021
MINIFICPP-1391 Replace usages of set-env set-env has been deprecated and triggers a warning; see https://github.blog/changelog/2020-10-01-github-actions-deprecating-set-env-and-add-path-commands/ MINIFICPP-1391 Remove the CMAKE_BUILD_OPTIONS env setting This environment setting doesn't do anything, and it gives the false appearance as if the Pcap extension was enabled (it isn't). As the Pcap extension is not in a good shape, I have left it disabled. ENABLE_LUA_SCRIPTING seems to work (at least it compiles), so I enabled it in the jobs where the intention was to enable it. MINIFICPP-1391 Increase the time limit on the docker test Cherry picked from main, where: Signed-off-by: Arpad Boda <aboda@apache.org> This closes apache#925
arpadboda
pushed a commit
that referenced
this pull request
Jan 4, 2021
…ing lua and duktape deps MINIFICPP-1405 - Add patch fixing how civetweb checks available compiler options Signed-off-by: Arpad Boda <aboda@apache.org> This closes #952 MINIFICPP-1391 Remove XCode 10.3 CI job, add 12.0 MINIFICPP-1391 Replace usages of set-env set-env has been deprecated and triggers a warning; see https://github.blog/changelog/2020-10-01-github-actions-deprecating-set-env-and-add-path-commands/ MINIFICPP-1391 Remove the CMAKE_BUILD_OPTIONS env setting This environment setting doesn't do anything, and it gives the false appearance as if the Pcap extension was enabled (it isn't). As the Pcap extension is not in a good shape, I have left it disabled. ENABLE_LUA_SCRIPTING seems to work (at least it compiles), so I enabled it in the jobs where the intention was to enable it. MINIFICPP-1391 Increase the time limit on the docker test Cherry picked from main, where: Signed-off-by: Arpad Boda <aboda@apache.org> This closes #925
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GitHub actions fixes:
set-env(see https://github.blog/changelog/2020-10-01-github-actions-deprecating-set-env-and-add-path-commands/)https://issues.apache.org/jira/browse/MINIFICPP-1391
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
Has your PR been rebased against the latest commit within the target branch (typically main)?
Is your initial contribution a single, squashed commit?
For code changes:
For documentation related changes:
Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible.