MINIFICPP-1462 Fix incorrect usage of move constructors and assignment operators#984
Closed
dam4rus wants to merge 3 commits intoapache:mainfrom
Closed
MINIFICPP-1462 Fix incorrect usage of move constructors and assignment operators#984dam4rus wants to merge 3 commits intoapache:mainfrom
dam4rus wants to merge 3 commits intoapache:mainfrom
Conversation
szaszm
approved these changes
Feb 1, 2021
Member
szaszm
left a comment
szaszm
left a comment
There was a problem hiding this comment.
Issues around copy/move were commonplace in the codebase for a long time, but most commonly touched and trivially changed parts are now fixed. Thanks for cleaning up more of these.
martinzink
pushed a commit
to martinzink/nifi-minifi-cpp
that referenced
this pull request
Feb 2, 2021
…t operators Signed-off-by: Arpad Boda <aboda@apache.org> This closes apache#984
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Apparently this PR raises some questions about how to properly fix this.
Some of the classes are actually never instantiated on the stack. So the move constructors are actually never called. All of the classes with deleted copy and move constructors in the PR are such classes. I think it's safer to delete the special functions for such classes instead of them doing something wrong if somehow they are called.
Other classes, like Peer, had only a move constructor which would lead to strange behaviors. A user-defined move constructor deletes the copy constructor, however they had defaulted copy and move assignment operators. So they could have been copied with assignment but not through constructor. I don't believe this was intentional?
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
Has your PR been rebased against the latest commit within the target branch (typically main)?
Is your initial contribution a single, squashed commit?
For code changes:
For documentation related changes:
Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible.