This repository was archived by the owner on Jul 22, 2021. It is now read-only.
Closed
Conversation
Replacing the test TLS certs in the source code repository with new certs that were signed by a tracked CA key. Also adding instructions for generating additional keys in the future if needed.
Contributor
|
Reviewing... |
alopresto
reviewed
Dec 18, 2018
nifi-registry-core/nifi-registry-web-api/src/test/resources/application-ITSecureFile.properties
Show resolved
Hide resolved
alopresto
reviewed
Dec 18, 2018
| server.ssl.key-store-password: localhostKeystorePassword | ||
| server.ssl.key-password: localhostKeystorePassword | ||
| server.ssl.key-store: ./target/test-classes/keys/registry-ks.jks | ||
| server.ssl.key-store-password: password |
Contributor
There was a problem hiding this comment.
These passwords seem to have gotten much weaker.
alopresto
reviewed
Dec 18, 2018
nifi-registry-core/nifi-registry-web-api/src/test/resources/keys/README.md
Outdated
Show resolved
Hide resolved
alopresto
reviewed
Dec 18, 2018
nifi-registry-core/nifi-registry-web-api/src/test/resources/keys/README.md
Outdated
Show resolved
Hide resolved
alopresto
reviewed
Dec 18, 2018
nifi-registry-core/nifi-registry-web-api/src/test/resources/keys/README.md
Outdated
Show resolved
Hide resolved
alopresto
reviewed
Dec 18, 2018
nifi-registry-core/nifi-registry-web-api/src/test/resources/keys/README.md
Outdated
Show resolved
Hide resolved
Contributor
Author
|
Thanks for the prompt review, @alopresto! I addressed those comments, let me know if there is anything else you come across. By the way, these certificates are used by the integration tests, which are not run by default during the build. You can verify nothing broke by running a build with the IT maven profile active:
|
Contributor
|
Ran |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replacing the test TLS certs in the source code repository
with new certs that were signed by a tracked CA key. Also
adding instructions for generating additional keys in the
future if needed.