Skip to content
This repository was archived by the owner on Jul 22, 2021. It is now read-only.

NIFIREG-232 Introducing flow persistence provider migrator and toolkit#159

Merged
bbende merged 2 commits intoapache:masterfrom
brosander:NIFIREG-232
Mar 12, 2019
Merged

NIFIREG-232 Introducing flow persistence provider migrator and toolkit#159
bbende merged 2 commits intoapache:masterfrom
brosander:NIFIREG-232

Conversation

@brosander
Copy link
Contributor

No description provided.

@brosander brosander force-pushed the NIFIREG-232 branch 2 times, most recently from a763839 to 8cf319b Compare March 1, 2019 18:37
@bbende
Copy link
Contributor

bbende commented Mar 1, 2019

@brosander this looks interesting, will definitely take a closer look soon

@brosander
Copy link
Contributor Author

brosander commented Mar 4, 2019

I probably need to add a readme section if this pr looks good to you @bbende

Usage:

  1. Shutdown registry
  2. Copy providers.xml -> providers-to.xml, edit to reflect what you'd like to migrate to (e.g. git)
  3. In registry home as working dir, run persistence-toolkit.sh -t providers-to.xml

I tested it by converting filesystem provider to git provider, then back to filesystem provider and diffing original, roundtrip directory.

Also by using it on a registry and verifying that everything looked right after conversion (could still get old versions of things, sync w/ nifi, etc)

Copy link
Contributor

@bbende bbende left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested this out and was able to migrate back and forth, definitely cool!

Besides the two minor comments, we probably need to document the usage somewhere. I guess we can add a "NiFi Registry Toolkit" section to the admin guide with a sub-section for each tool, currently just the persistence migrator.

Was thinking about it more, and maybe instead of the admin guide we can do something less formal and just add a README to the root of nifi-registry-toolkit module.

@brosander
Copy link
Contributor Author

I can add to the admin guide and update the doc around changing flow persistence providers as well.

@bbende
Copy link
Contributor

bbende commented Mar 11, 2019

Thanks for addressing the feedback. For the documentation, we can probably just have a README in the nifi-registry-toolkit module, and then if we end up adding more tools and have a significant amount of content, we can promote it to a nifi registry toolkit guide like we did in NiFi.

@brosander
Copy link
Contributor Author

@bbende I think I've addressed your feedback, please let me know if more changes are needed

@bbende
Copy link
Contributor

bbende commented Mar 12, 2019

@brosander looks good, thanks! Going to merge

@bbende bbende merged commit cf0e35b into apache:master Mar 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants