This repository was archived by the owner on Jul 22, 2021. It is now read-only.
Closed
Conversation
…me changes to integration tests. Minor JettyServer change.
bbende
reviewed
Jul 29, 2019
| <dependency> | ||
| <groupId>org.eclipse.jetty</groupId> | ||
| <artifactId>jetty-util</artifactId> | ||
| <version>9.4.19.v20190610</version> |
Contributor
There was a problem hiding this comment.
Should this be ${jetty.version} so it stays in sync the next time we upgrade?
…IdentificationAlgorithm(null). This is called by SslContextFactory.Server()
Contributor
|
Looks good now, going to merge, thanks! |
ekovacs
pushed a commit
to ekovacs/nifi-registry-apache
that referenced
this pull request
Sep 20, 2019
…me changes to integration tests. Minor JettyServer change. - Used jetty.version parameter for test scope dependency - Added comments and removed explicit call to setEndpointIdentificationAlgorithm(null). This is called by SslContextFactory.Server() This closes apache#208. Signed-off-by: Bryan Bende <bbende@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgraded Jetty version to 9.4.19.v20190610. Required some changes to integration tests. Minor JettyServer change.