Skip to content
This repository was archived by the owner on Jul 22, 2021. It is now read-only.

NIFIREG-75 Fix User Groups for Composite Provider Config#64

Closed
kevdoran wants to merge 1 commit intoapache:masterfrom
kevdoran:NIFIREG-75
Closed

NIFIREG-75 Fix User Groups for Composite Provider Config#64
kevdoran wants to merge 1 commit intoapache:masterfrom
kevdoran:NIFIREG-75

Conversation

@kevdoran
Copy link
Contributor

@kevdoran kevdoran commented Dec 21, 2017

Removes user existence check from FileUserGroupProvider when group is created or updated. Replaces it with check in the Authorizer Decorator class created by Authorizer Factory, so that all providers are used. Also fixes bug when searching for group membership by user that returns results across all providers.

Also updates a package name in the authorizers.xml template.

UI fix for group membership deletion icon in user side panel.

@kevdoran kevdoran changed the title NIFIREG-75 Add check for user when updating group NIFIREG-75 Fix User Group Data Integrity Checks Dec 22, 2017
@kevdoran
Copy link
Contributor Author

This has been updated with the latest approach

@kevdoran kevdoran changed the title NIFIREG-75 Fix User Group Data Integrity Checks NIFIREG-75 Fix User Groups for Composite Provider Config Dec 22, 2017
@bbende
Copy link
Contributor

bbende commented Dec 22, 2017

Reviewing...

Removes user existence check from FileUserGroupProvider when
group is created or updated. Replaces it with check in the
Authorizer Decorator class created by Authorizer Factory, so
that all providers are used. Also fixes bug when searching
for group membership by user that returns results across all
providers.

Also updates a package in the authorizers.xml template.

UI fixes for action icon enabled/disabled states in Administration.
@bbende
Copy link
Contributor

bbende commented Dec 22, 2017

+1 Ran through a full test with NiFi & Registry both configured with a composite user-group-provider, and put an LDAP user into a file-based group, and then made a bucket and gave the group access to that bucket, verified the LDAP user could use that bucket from NiFi... nice work

@asfgit asfgit closed this in a94b817 Dec 22, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants