[NIFI-14707] Use a single logger for TimedLock#10064
[NIFI-14707] Use a single logger for TimedLock#10064exceptionfactory merged 1 commit intoapache:mainfrom
Conversation
exceptionfactory
left a comment
There was a problem hiding this comment.
Thanks for digging into this issue @esecules. I agree that this change is going in the right direction, creating numerous loggers is definitely wasteful.
I recommend going a step further and initializing the logger statically, since it will always be the same, it doesn't need to be an instance member variable.
…rt and make sure that all log messages include the lock name
6817350 to
21fb937
Compare
Done. Thanks. |
exceptionfactory
left a comment
There was a problem hiding this comment.
Thanks for the adjustment and discovering this latent issue, looks good! +1 merging
Summary
NIFI-14707
Go with the simple approach to use a single logger for all instances of TimedLock and its debuggable counterpart. If you all still want the ability to configure logging on a specific TimedLock instance please drop a comment. I just wanted to get a PR up with the simplest solution.
Tracking
Please complete the following tracking steps prior to pull request creation.
Issue Tracking
Pull Request Tracking
NIFI-00000NIFI-00000Pull Request Formatting
mainbranchVerification
Please indicate the verification steps performed prior to pull request creation.
Build
mvn clean install -P contrib-checkLicensing
LICENSEandNOTICEfilesDocumentation