AbstractKiteProcessor.getSchema leaks file handles#101
Closed
jackowaya wants to merge 1 commit intoapache:masterfrom
Closed
AbstractKiteProcessor.getSchema leaks file handles#101jackowaya wants to merge 1 commit intoapache:masterfrom
jackowaya wants to merge 1 commit intoapache:masterfrom
Conversation
Contributor
|
+1, lgtm |
Contributor
|
Is there a JIRA associated with this? |
Author
|
Yes. I screwed up making the commit message. It's https://issues.apache.org/jira/browse/NIFI-1035 |
Close file handles when reading schema from resources or paths in AbstractKiteProcessor.getSchema
Author
|
Just force pushed with a message that has the jira ID in it. Hopefully that doesn't screw anything up. |
Contributor
|
No worries, it still looks good to me :) |
Contributor
|
+1, thanks for fixing this @jackowaya! |
Contributor
|
looks good - am merging. Sorry for the delay Alan |
JPercivall
pushed a commit
to JPercivall/nifi
that referenced
this pull request
Apr 23, 2018
…and making use of a mirror instead of Apache dist. Signed-off-by: joewitt <joewitt@apache.org>
iadamcsik
pushed a commit
to iadamcsik/nifi
that referenced
this pull request
Oct 22, 2025
- CDPDFX-6813 Fix use of flow comparator in standard flow change event handler - CDPDFX-6813 Remove duplicate NAR in assembly - CDPDFX-6831 Fix publishing of controller service bulletins (apache#101) - CDPDFX-6854: Correcting process group ID mapping in flow bulletin task (apache#102) - CDPDFX-6848: Ensuring that all child components are included in each published BulletinGroup. This separation allows them to not be pruned when there are many other descendent components.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close file handles when reading schema from resources or paths in AbstractKiteProcessor.getSchema