Skip to content

NIFI-14736 Add EOF attribute to ExecuteSQL for the last FlowFile output for a ResultSet#10121

Closed
takraj wants to merge 1 commit intoapache:mainfrom
takraj:pr/NIFI-14736_eof_file_as_sentinel
Closed

NIFI-14736 Add EOF attribute to ExecuteSQL for the last FlowFile output for a ResultSet#10121
takraj wants to merge 1 commit intoapache:mainfrom
takraj:pr/NIFI-14736_eof_file_as_sentinel

Conversation

@takraj
Copy link
Contributor

@takraj takraj commented Jul 22, 2025

Summary

NIFI-14736

Tracking

Please complete the following tracking steps prior to pull request creation.

Issue Tracking

Pull Request Tracking

  • Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-00000
  • Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-00000

Pull Request Formatting

  • Pull Request based on current revision of the main branch
  • Pull Request refers to a feature branch with one commit containing changes

Verification

Please indicate the verification steps performed prior to pull request creation.

Build

  • Build completed using mvn clean install -P contrib-check
    • JDK 21

Licensing

  • New dependencies are compatible with the Apache License 2.0 according to the License Policy
  • New dependencies are documented in applicable LICENSE and NOTICE files

Documentation

  • Documentation formatting appears as expected in rendered files

Copy link
Contributor

@exceptionfactory exceptionfactory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for describing this alternative approach in the draft pull request @takraj. I will leave this open for a bit longer, but it would be helpful to continue working through the original approach in the linked PR for now.

@exceptionfactory
Copy link
Contributor

Based on the discussion in the linked pull request regarding use of existing fragment attributes, leading to the need to reconsider the general approach, I'm closing this pull request for now. We can continue the discussion on the linked pull request, or move back to Jira for additional reconsideration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants