NIFI-14732 Delete references to removed encrypted repo classes#10207
NIFI-14732 Delete references to removed encrypted repo classes#10207exceptionfactory merged 3 commits intoapache:mainfrom
Conversation
EncryptedSequentialAccessWriteAheadLog EncryptedWriteAheadProvenanceRepository
exceptionfactory
left a comment
exceptionfactory
left a comment
There was a problem hiding this comment.
Thanks for cleaning up these references @jrsteinebrey. The changes look good in general, but there additional catch seems unnecessary.
| // TODO: May need to instantiate ESAWAL for clarity? | ||
| wal = new SequentialAccessWriteAheadLog<>(flowFileRepositoryPaths.get(0), serdeFactory, this); | ||
| } else { | ||
| } catch (final Exception ex) { |
There was a problem hiding this comment.
This catch seems unnecessary because there is only one implementation of the Write-Ahead Log supported.
exceptionfactory
left a comment
exceptionfactory
left a comment
There was a problem hiding this comment.
Thanks for the updates @jrsteinebrey. I agree with removing the property from NiFiProperties, and as a result, the admin guide should be updated to remove the reference to that property. The historical TODO comment should also be removed.
| in order to address an issue that exists in the older implementation. In the event of power loss or an operating system crash, the old implementation was susceptible to recovering FlowFiles | ||
| incorrectly. This could potentially lead to the wrong attributes or content being assigned to a FlowFile upon restart, following the power loss or OS crash. However, one can still choose to opt into | ||
| using the previous implementation and accept that risk, if desired (for example, if the new implementation were to exhibit some unexpected error). | ||
| To do so, set the value of this property to `org.wali.MinimalLockingWriteAheadLog`. Another available implementation is `org.apache.nifi.wali.EncryptedSequentialAccessWriteAheadLog`. | ||
| To do so, set the value of this property to `org.wali.MinimalLockingWriteAheadLog`. |
There was a problem hiding this comment.
This entire property description can now be removed since there are no other implementations
| "' has an invalid value of '" + walImplementation + "'. Please update nifi.properties to indicate a valid value for this property."); | ||
| } | ||
|
|
||
| // TODO: May need to instantiate ESAWAL for clarity? |
There was a problem hiding this comment.
The TODO comment no longer applies, it was referring to the encrypted implementation.
exceptionfactory
left a comment
exceptionfactory
left a comment
There was a problem hiding this comment.
Thanks again for the cleanup @jrsteinebrey, this looks good now! +1 merging
…he#10207) (cherry picked from commit 3f1b948926f9c63d86fc2703b1875ea70ecd8f90)
2 participants
NIFI-14732 Delete references to removed classes:
EncryptedSequentialAccessWriteAheadLog
EncryptedWriteAheadProvenanceRepository
Summary
NIFI-14732
Tracking
Please complete the following tracking steps prior to pull request creation.
Issue Tracking
Pull Request Tracking
NIFI-14732NIFI-14732Pull Request Formatting
mainbranchVerification
Ran the NiFi service locally and ran a data flow.
Build
./mvnw clean install -P contrib-checkLicensing
No changes
Documentation