NIFI-14947 Simplified StandardIssuerProviderTest URI Host checking#10285
Closed
exceptionfactory wants to merge 1 commit intoapache:mainfrom
Closed
NIFI-14947 Simplified StandardIssuerProviderTest URI Host checking#10285exceptionfactory wants to merge 1 commit intoapache:mainfrom
exceptionfactory wants to merge 1 commit intoapache:mainfrom
Conversation
3899075 to
bcaf3cb
Compare
pvillard31
approved these changes
Sep 9, 2025
- Replaced local host equality checking with empty string checking to avoid failures on macOS 14.7.6 with Java 21.0.8 running in GitHub - Added empty check for Canonical Host Name and returned Host Address
bcaf3cb to
db040f7
Compare
Contributor
Author
|
The problem actually relates to the use of invalid characters in the hostname, closing this pull request and following up with a new approach. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NIFI-14947 Simplifies the unit test method in
StandardIssuerProviderTestthat is responsible for evaluating the resolution when the input host property innull. The updated assertion expects a non-empty string as opposed to expecting a particular host value. This change avoids apparent inconsistent test behavior on macOS 14.7.6 with Java 21.0.8 when running on GitHub workflows.Tracking
Please complete the following tracking steps prior to pull request creation.
Issue Tracking
Pull Request Tracking
NIFI-00000NIFI-00000Pull Request Formatting
mainbranchVerification
Please indicate the verification steps performed prior to pull request creation.
Build
./mvnw clean install -P contrib-checkLicensing
LICENSEandNOTICEfilesDocumentation