Skip to content

NIFI-14982 - Bump Snowflake Ingest SDK to 4.3.0 and Snowflake JDBC to 3.25.1#10313

Merged
exceptionfactory merged 2 commits intoapache:mainfrom
pvillard31:NIFI-14982
Sep 18, 2025
Merged

NIFI-14982 - Bump Snowflake Ingest SDK to 4.3.0 and Snowflake JDBC to 3.25.1#10313
exceptionfactory merged 2 commits intoapache:mainfrom
pvillard31:NIFI-14982

Conversation

@pvillard31
Copy link
Copy Markdown
Contributor

Summary

NIFI-14982 - Bump Snowflake Ingest SDK to 4.3.0 and Snowflake JDBC to 3.25.1.

Also add an integration test that can be executed to confirm that all processors are working as expected.

The new integration test can be executed using:

JAVA_HOME=/Library/Java/JavaVirtualMachines/zulu-21.jdk/Contents/Home \
NIFI_SNOWFLAKE_URL=xxx \
NIFI_SNOWFLAKE_USER=xxx \
NIFI_SNOWFLAKE_PASSWORD=xxx \
NIFI_SNOWFLAKE_WAREHOUSE=xxx \
NIFI_SNOWFLAKE_PRIVATE_KEY_PATH=xxx \
NIFI_SNOWFLAKE_PRIVATE_KEY_PASSPHRASE=xxx \
NIFI_SNOWFLAKE_ROLE=ACCOUNTADMIN \
mvn -pl nifi-extension-bundles/nifi-snowflake-bundle/nifi-snowflake-processors \
      -P integration-tests,skip-unit-tests \
      -DargLine="--add-opens=java.base/java.nio=org.apache.arrow.memory.core,ALL-UNNAMED" \
      -Dit.test=SnowflakeIngestIT verify

Tracking

Please complete the following tracking steps prior to pull request creation.

Issue Tracking

Pull Request Tracking

  • Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-00000
  • Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-00000

Pull Request Formatting

  • Pull Request based on current revision of the main branch
  • Pull Request refers to a feature branch with one commit containing changes

Verification

Please indicate the verification steps performed prior to pull request creation.

Build

  • Build completed using ./mvnw clean install -P contrib-check
    • JDK 21
    • JDK 25

Licensing

  • New dependencies are compatible with the Apache License 2.0 according to the License Policy
  • New dependencies are documented in applicable LICENSE and NOTICE files

Documentation

  • Documentation formatting appears as expected in rendered files

Copy link
Copy Markdown
Contributor

@exceptionfactory exceptionfactory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this driver upgrade and additional test @pvillard31.

As noted, I don't think having a test dependency on nifi-standard-processors is a good strategy due to the coupling. If the integration test can be reworked to use direct JDBC, that would be good, otherwise, it may be better to avoid including the new integration test.

Also of note, the EnabledIf annotation should be used to ignore the test class if an environment variable like NIFI_SNOWFLAKE_URL is not defined.

</dependency>
<dependency>
<groupId>org.apache.nifi</groupId>
<artifactId>nifi-standard-processors</artifactId>
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding nifi-standard-processors even as a test dependency is concerning in terms of coupling. Although ExecuteSQLRecord is convenient, I don't recommend building a test against it in this scenario.

@pvillard31
Copy link
Copy Markdown
Contributor Author

Thanks @exceptionfactory - this is a good point, I went with ExecuteSQLRecord to simulate the flow that I was using locally to test the changes but I can directly use the Snowflake Connection Pool controller service.

Copy link
Copy Markdown
Contributor

@exceptionfactory exceptionfactory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the test and dependency adjustments @pvillard31, looks good! +1 merging

@exceptionfactory exceptionfactory merged commit f355348 into apache:main Sep 18, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants