NIFI-14982 - Bump Snowflake Ingest SDK to 4.3.0 and Snowflake JDBC to 3.25.1#10313
NIFI-14982 - Bump Snowflake Ingest SDK to 4.3.0 and Snowflake JDBC to 3.25.1#10313exceptionfactory merged 2 commits intoapache:mainfrom
Conversation
exceptionfactory
left a comment
There was a problem hiding this comment.
Thanks for working on this driver upgrade and additional test @pvillard31.
As noted, I don't think having a test dependency on nifi-standard-processors is a good strategy due to the coupling. If the integration test can be reworked to use direct JDBC, that would be good, otherwise, it may be better to avoid including the new integration test.
Also of note, the EnabledIf annotation should be used to ignore the test class if an environment variable like NIFI_SNOWFLAKE_URL is not defined.
| </dependency> | ||
| <dependency> | ||
| <groupId>org.apache.nifi</groupId> | ||
| <artifactId>nifi-standard-processors</artifactId> |
There was a problem hiding this comment.
Adding nifi-standard-processors even as a test dependency is concerning in terms of coupling. Although ExecuteSQLRecord is convenient, I don't recommend building a test against it in this scenario.
|
Thanks @exceptionfactory - this is a good point, I went with ExecuteSQLRecord to simulate the flow that I was using locally to test the changes but I can directly use the Snowflake Connection Pool controller service. |
bc7c5fe to
2006e0c
Compare
2006e0c to
870583e
Compare
exceptionfactory
left a comment
There was a problem hiding this comment.
Thanks for making the test and dependency adjustments @pvillard31, looks good! +1 merging
Summary
NIFI-14982 - Bump Snowflake Ingest SDK to 4.3.0 and Snowflake JDBC to 3.25.1.
Also add an integration test that can be executed to confirm that all processors are working as expected.
The new integration test can be executed using:
Tracking
Please complete the following tracking steps prior to pull request creation.
Issue Tracking
Pull Request Tracking
NIFI-00000NIFI-00000Pull Request Formatting
mainbranchVerification
Please indicate the verification steps performed prior to pull request creation.
Build
./mvnw clean install -P contrib-checkLicensing
LICENSEandNOTICEfilesDocumentation