NIFI-14471 clear branch value when switching between registry clients…#10383
Merged
rfellows merged 2 commits intoapache:mainfrom Oct 6, 2025
Merged
NIFI-14471 clear branch value when switching between registry clients…#10383rfellows merged 2 commits intoapache:mainfrom
rfellows merged 2 commits intoapache:mainfrom
Conversation
… in the import from registry form
Contributor
|
Will review... |
rfellows
requested changes
Oct 3, 2025
Contributor
rfellows
left a comment
rfellows
left a comment
There was a problem hiding this comment.
Your solution works well, there is just one minor optimization we can now take as a result.
...es/flow-designer/ui/canvas/items/flow/import-from-registry/import-from-registry.component.ts
Outdated
Show resolved
Hide resolved
rfellows
approved these changes
Oct 3, 2025
Contributor
rfellows
left a comment
rfellows
left a comment
There was a problem hiding this comment.
Nice work @markobean, thanks for the fix! 👍
Contributor
Author
|
FWIW - after the latest change, I repeated my test in a running NiFi. Everything continued to work well. |
Contributor
Thanks, I had tested out that change locally before suggesting it as well. I'll merge this once CI is green. Thanks again! |
Contributor
Author
|
Thanks Rob
…On Mon, Oct 6, 2025 at 8:29 AM Rob Fellows ***@***.***> wrote:
Merged #10383 <#10383> into main.
—
Reply to this email directly, view it on GitHub
<#10383 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AEALDSFRWLAXO5WP2TV27X33WJOD5AVCNFSM6AAAAACIHOFCA2VHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMRQGEYTGOJXGI4DGNQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
awelless
pushed a commit
to awelless/nifi
that referenced
this pull request
Nov 5, 2025
apache#10383) * NIFI-14471 clear branch value when switching between registry clients in the import from registry form * NIFI-14471 optimize by removing redundant method call This closes apache#10383
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… in the import from registry form
Summary
NiFi can be configured with multiple Registry clients. When multiple clients have at least one that supports branching, e.g. GitHubFlowRegistryClient, and another which does not, e.g. NifiRegistryFlowRegistryClient, the client not supporting branching was being handed branch information. The information was a remnant from the branch-supporting client. Worse, if that branch name was not "main", an error was thrown.
On the "import from registry" form in the UI, the code was updated so that the branch details are wiped each time the registry selection is changed thereby preventing branches from being included in the API calls for non-supporting clients.
NIFI-14471
Tracking
Please complete the following tracking steps prior to pull request creation.
Issue Tracking
Pull Request Tracking
NIFI-00000NIFI-00000Pull Request Formatting
mainbranchVerification
See Jira issue for steps to reproduce - except where the error is reported in the issue, the import of a dataflow should succeed.
Please indicate the verification steps performed prior to pull request creation.
Build
./mvnw clean install -P contrib-checkLicensing
LICENSEandNOTICEfilesDocumentation