NIFI-15024 - Add executed query as a FlowFile attribute for ExecuteSQL and ExecuteSQLRecord#10392
Conversation
exceptionfactory
left a comment
There was a problem hiding this comment.
Thanks for proposing this addition @pvillard31.
The implementation looks good, but it does raise the question of large attribute values. Logging the SQL is one thing, but adding it as an output attribute is another. If the goal is simply for troubleshooting, I'm not sure that is sufficient to warrant the addition, as useful as it could be. Making it an optional addition with a new property could work, although that seems to introduce unnecessary complexity. Do you have any concerns about the attribute size, or use cases outside of troubleshooting?
|
Thanks for the feedback @exceptionfactory - I decided to just switch the log statement to info as a good first step and we can revisit later if it's not enough. |
exceptionfactory
left a comment
There was a problem hiding this comment.
Thanks @pvillard31, changing the log level seems like a better approach under the circumstances. Since WARN is the default level, this avoids changing default behavior, but makes it easier to enable logging SQL statements without additional debug details. +1 merging
…pache#10392) Signed-off-by: David Handermann <exceptionfactory@apache.org>
Summary
NIFI-15024 - Add executed query as a FlowFile attribute for ExecuteSQL and ExecuteSQLRecord
Tracking
Please complete the following tracking steps prior to pull request creation.
Issue Tracking
Pull Request Tracking
NIFI-00000NIFI-00000Pull Request Formatting
mainbranchVerification
Please indicate the verification steps performed prior to pull request creation.
Build
./mvnw clean install -P contrib-checkLicensing
LICENSEandNOTICEfilesDocumentation