Skip to content

NIFI-15088 Refactor Login Provider loading with DOM instead of JAXB#10416

Closed
exceptionfactory wants to merge 1 commit into
apache:mainfrom
exceptionfactory:NIFI-15088
Closed

NIFI-15088 Refactor Login Provider loading with DOM instead of JAXB#10416
exceptionfactory wants to merge 1 commit into
apache:mainfrom
exceptionfactory:NIFI-15088

Conversation

@exceptionfactory
Copy link
Copy Markdown
Contributor

Summary

NIFI-15088 Refactors framework loading of the login-identity-providers.xml configuration using the XML DOM API instead of JAXB.

The XML schema for Login Identity Providers is straightforward with a small number of elements and attributes. Moving away from JAXB avoids both build dependencies on the Maven plugin for compiling Java classes from an XSD, and runtime dependencies on JAXB for loading XML.

The existing unit tests exercise the Login Identity Provider loading process, validating these changes.

Tracking

Please complete the following tracking steps prior to pull request creation.

Issue Tracking

Pull Request Tracking

  • Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-00000
  • Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-00000

Pull Request Formatting

  • Pull Request based on current revision of the main branch
  • Pull Request refers to a feature branch with one commit containing changes

Verification

Please indicate the verification steps performed prior to pull request creation.

Build

  • Build completed using ./mvnw clean install -P contrib-check
    • JDK 21
    • JDK 25

Licensing

  • New dependencies are compatible with the Apache License 2.0 according to the License Policy
  • New dependencies are documented in applicable LICENSE and NOTICE files

Documentation

  • Documentation formatting appears as expected in rendered files

@exceptionfactory exceptionfactory changed the title NIFI-15088 Refactor Login Provider loading DOM instead of JAXB NIFI-15088 Refactor Login Provider loading with DOM instead of JAXB Oct 14, 2025
Copy link
Copy Markdown
Contributor

@pvillard31 pvillard31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @exceptionfactory, this looks good and a much better approach! Tested this PR and #10417 together.

@exceptionfactory exceptionfactory added the hacktoberfest-accepted Hacktoberfest Accepted label Oct 16, 2025
awelless pushed a commit to awelless/nifi that referenced this pull request Nov 5, 2025
Signed-off-by: Pierre Villard <pierre.villard.fr@gmail.com>

This closes apache#10416.
yisun-anetac pushed a commit to Eng-Anetac/nifi that referenced this pull request Apr 4, 2026
Signed-off-by: Pierre Villard <pierre.villard.fr@gmail.com>

This closes apache#10416.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hacktoberfest-accepted Hacktoberfest Accepted

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants