Skip to content

NIFI-15133 Add Reusable Test Database Pool for Standard Processors#10457

Closed
exceptionfactory wants to merge 2 commits intoapache:mainfrom
exceptionfactory:NIFI-15133
Closed

NIFI-15133 Add Reusable Test Database Pool for Standard Processors#10457
exceptionfactory wants to merge 2 commits intoapache:mainfrom
exceptionfactory:NIFI-15133

Conversation

@exceptionfactory
Copy link
Contributor

Summary

NIFI-15133 Adds a reusable EmbeddedDatabaseConnectionService to the test directory for nifi-standard-processors and refactors QueryDatabaseTableRecordTest, TestListDatabaseTables, and TestUpdateDatabaseTable to use the new service.

The new shared service removes duplicative test code and inconsistent temporary directory usage across multiple Processors. This is an initial set of changes for selected test Processors, subsequent issues can implement changes to remaining Processor test classes.

Changes also include removing the QueryDatabaseTableRecordIT, which used PostgreSQL with Testcontainers but otherwise ran the same set of tests designed for Apache Derby.

Tracking

Please complete the following tracking steps prior to pull request creation.

Issue Tracking

Pull Request Tracking

  • Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-00000
  • Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-00000

Pull Request Formatting

  • Pull Request based on current revision of the main branch
  • Pull Request refers to a feature branch with one commit containing changes

Verification

Please indicate the verification steps performed prior to pull request creation.

Build

  • Build completed using ./mvnw clean install -P contrib-check
    • JDK 21
    • JDK 25

Licensing

  • New dependencies are compatible with the Apache License 2.0 according to the License Policy
  • New dependencies are documented in applicable LICENSE and NOTICE files

Documentation

  • Documentation formatting appears as expected in rendered files

@exceptionfactory
Copy link
Contributor Author

Thanks for the feedback @dan-s1, I refactored that test class using shared methods for table creation and row insertion.

@exceptionfactory
Copy link
Contributor Author

Thanks again for the feedback @dan-s1, any additional comments, or does this look ready to merge?

Copy link
Contributor

@pvillard31 pvillard31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a +1, thanks @exceptionfactory
@dan-s1 - if you're ok, I can go ahead and merge

@exceptionfactory exceptionfactory added the hacktoberfest-accepted Hacktoberfest Accepted label Oct 27, 2025
awelless pushed a commit to awelless/nifi that referenced this pull request Nov 5, 2025
Signed-off-by: Pierre Villard <pierre.villard.fr@gmail.com>

This closes apache#10457.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hacktoberfest-accepted Hacktoberfest Accepted

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants