NIFI-15133 Add Reusable Test Database Pool for Standard Processors#10457
Closed
exceptionfactory wants to merge 2 commits intoapache:mainfrom
Closed
NIFI-15133 Add Reusable Test Database Pool for Standard Processors#10457exceptionfactory wants to merge 2 commits intoapache:mainfrom
exceptionfactory wants to merge 2 commits intoapache:mainfrom
Conversation
dan-s1
reviewed
Oct 23, 2025
...ard-processors/src/test/java/org/apache/nifi/processors/standard/TestListDatabaseTables.java
Outdated
Show resolved
Hide resolved
...ard-processors/src/test/java/org/apache/nifi/processors/standard/TestListDatabaseTables.java
Outdated
Show resolved
Hide resolved
Contributor
Author
|
Thanks for the feedback @dan-s1, I refactored that test class using shared methods for table creation and row insertion. |
Contributor
Author
|
Thanks again for the feedback @dan-s1, any additional comments, or does this look ready to merge? |
pvillard31
approved these changes
Oct 24, 2025
Contributor
pvillard31
left a comment
There was a problem hiding this comment.
I'm a +1, thanks @exceptionfactory
@dan-s1 - if you're ok, I can go ahead and merge
awelless
pushed a commit
to awelless/nifi
that referenced
this pull request
Nov 5, 2025
Signed-off-by: Pierre Villard <pierre.villard.fr@gmail.com> This closes apache#10457.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NIFI-15133 Adds a reusable
EmbeddedDatabaseConnectionServiceto the test directory fornifi-standard-processorsand refactorsQueryDatabaseTableRecordTest,TestListDatabaseTables, andTestUpdateDatabaseTableto use the new service.The new shared service removes duplicative test code and inconsistent temporary directory usage across multiple Processors. This is an initial set of changes for selected test Processors, subsequent issues can implement changes to remaining Processor test classes.
Changes also include removing the
QueryDatabaseTableRecordIT, which used PostgreSQL with Testcontainers but otherwise ran the same set of tests designed for Apache Derby.Tracking
Please complete the following tracking steps prior to pull request creation.
Issue Tracking
Pull Request Tracking
NIFI-00000NIFI-00000Pull Request Formatting
mainbranchVerification
Please indicate the verification steps performed prior to pull request creation.
Build
./mvnw clean install -P contrib-checkLicensing
LICENSEandNOTICEfilesDocumentation