Skip to content

NIFI-15151 Refactor Processor Tests using Shared Database Service#10474

Closed
exceptionfactory wants to merge 1 commit intoapache:mainfrom
exceptionfactory:NIFI-15151
Closed

NIFI-15151 Refactor Processor Tests using Shared Database Service#10474
exceptionfactory wants to merge 1 commit intoapache:mainfrom
exceptionfactory:NIFI-15151

Conversation

@exceptionfactory
Copy link
Contributor

Summary

NIFI-15151 Refactors multiple tests in nifi-standard-processors using the shared EmbeddedDatabaseConnectionService to run unit tests with Apache Derby.

The refactored approach adds an abstract test class with lifecycle methods for creating and closing the embedded Apache Derby database using a JUnit temporary directory, and also provides methods to create new TestRunner instances with enabled DBCPService property settings applied.

The refactored approach reduces a significant amount of boilerplate code in multiple tests, but does not include a complete restructuring of duplicative table creation statements.

Tracking

Please complete the following tracking steps prior to pull request creation.

Issue Tracking

Pull Request Tracking

  • Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-00000
  • Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-00000

Pull Request Formatting

  • Pull Request based on current revision of the main branch
  • Pull Request refers to a feature branch with one commit containing changes

Verification

Please indicate the verification steps performed prior to pull request creation.

Build

  • Build completed using ./mvnw clean install -P contrib-check
    • JDK 21
    • JDK 25

Licensing

  • New dependencies are compatible with the Apache License 2.0 according to the License Policy
  • New dependencies are documented in applicable LICENSE and NOTICE files

Documentation

  • Documentation formatting appears as expected in rendered files

- Added AbstractDatabaseConnectionServiceTest with lifecycle handling
Copy link
Contributor

@pvillard31 pvillard31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the cleanup @exceptionfactory !

@exceptionfactory exceptionfactory added the hacktoberfest-accepted Hacktoberfest Accepted label Oct 29, 2025
awelless pushed a commit to awelless/nifi that referenced this pull request Nov 5, 2025
- Added AbstractDatabaseConnectionServiceTest with lifecycle handling

Signed-off-by: Pierre Villard <pierre.villard.fr@gmail.com>

This closes apache#10474.
mark-bathori pushed a commit to mark-bathori/nifi that referenced this pull request Feb 5, 2026
- Added AbstractDatabaseConnectionServiceTest with lifecycle handling

Signed-off-by: Pierre Villard <pierre.villard.fr@gmail.com>

This closes apache#10474.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hacktoberfest-accepted Hacktoberfest Accepted

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants