NIFI-2803 The pagination of GenerateTableFetch has a sort bug#1052
Closed
combineads wants to merge 1 commit intoapache:masterfrom
Closed
NIFI-2803 The pagination of GenerateTableFetch has a sort bug#1052combineads wants to merge 1 commit intoapache:masterfrom
combineads wants to merge 1 commit intoapache:masterfrom
Conversation
combineads
force-pushed
the
NIFI-2803
branch
from
0275a8d to
7ac09bb
Compare
combineads
force-pushed
the
NIFI-2803
branch
from
7ac09bb to
a14b78c
Compare
Contributor
|
Reviewing... |
Contributor
|
This commit breaks some unit tests that check the SQL statement(s) being generated, I will fix the tests before merging. Otherwise +1 LGTM, merging to master, thanks much for your contribution! |
trixpan
pushed a commit
to trixpan/nifi
that referenced
this pull request
Sep 30, 2016
Signed-off-by: Matt Burgess <mattyb149@apache.org> NIFI-2803: Updated unit tests for GenerateTableFetch Signed-off-by: Matt Burgess <mattyb149@apache.org> This closes apache#1052
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When data is coming to the ingested table, the pagination SQL needs the ORDER BY statement with maxValueClauses.
If maxValueClauses are not the primary keys, incoming data usually inserts using primary keys. So when ExecuteSQL executes, some data may be lost.