Dummy commit focused in closing stalled PR requests#1054
Closed
trixpan wants to merge 1 commit intoapache:masterfrom
Closed
Dummy commit focused in closing stalled PR requests#1054trixpan wants to merge 1 commit intoapache:masterfrom
trixpan wants to merge 1 commit intoapache:masterfrom
Conversation
trixpan
force-pushed
the
stalled_pr_cleanup
branch
from
46c7a8e to
319c4ed
Compare
Closes: apache#335 - superseded by apache#366 Closes: apache#849 - superseded by apache#875 Closes: apache#769 - malformed PR Closes: apache#595 - malformed PR
trixpan
force-pushed
the
stalled_pr_cleanup
branch
from
dca5b89 to
0847da3
Compare
Member
|
@trixpan Yep, looks good, and also agree with the superseded items. Thanks for combing through and finding these. Personally, I think this is good to go, but will give the email thread in Apache a bit more time to see if other folks have an opinion otherwise. |
Contributor
Author
|
@apiri should we go ahead and commit the PR? |
Member
|
@trixpan yeah, feel free to merge. I think there has been sufficient time for folks to chime in. Thanks! |
Contributor
Author
|
@apiri done |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@apiri
hope this is what you had in mind.
Cheers