Skip to content

NIFI-15238 Enforced the value for the HTTP_METHOD property in InvokeHTTP when not specified as an Expression Language Expression.#10551

Closed
dan-s1 wants to merge 1 commit intoapache:mainfrom
dan-s1:NIFI-15238
Closed

NIFI-15238 Enforced the value for the HTTP_METHOD property in InvokeHTTP when not specified as an Expression Language Expression.#10551
dan-s1 wants to merge 1 commit intoapache:mainfrom
dan-s1:NIFI-15238

Conversation

@dan-s1
Copy link
Contributor

@dan-s1 dan-s1 commented Nov 20, 2025

Summary

NIFI-15238

Tracking

Please complete the following tracking steps prior to pull request creation.

Issue Tracking

Pull Request Tracking

  • Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-00000
  • Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-00000

Pull Request Formatting

  • Pull Request based on current revision of the main branch
  • Pull Request refers to a feature branch with one commit containing changes

Verification

Please indicate the verification steps performed prior to pull request creation.

Build

  • Build completed using ./mvnw clean install -P contrib-check
    • JDK 21
    • JDK 25

Licensing

  • New dependencies are compatible with the Apache License 2.0 according to the License Policy
  • New dependencies are documented in applicable LICENSE and NOTICE files

Documentation

  • Documentation formatting appears as expected in rendered files

…TTP when not specified as an Expression Language Expression.
Copy link
Contributor

@exceptionfactory exceptionfactory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for proposing this improvement @dan-s1.

Although the validator includes standard methods, I don't think requiring an Expression Language literal is a great solution.

Methods such as TRACE are unlikely to be used, but it is difficult to know given the current property descriptor. Based on the long-standing history of this Processor and widespread adoption, I think it is better to avoid making this change and just leave it as-is.

@dan-s1
Copy link
Contributor Author

dan-s1 commented Nov 24, 2025

@exceptionfactory I understand. The motivation of this suggestion was based on a teammate's frustration that there is no immediate validation when a value other than an alternate method and a Expression Language expression were entered. Is there perhaps another way that you could think of which would allow for immediate validation on the basic HTTP methods?

@exceptionfactory
Copy link
Contributor

@exceptionfactory I understand. The motivation of this suggestion was based on a teammate's frustration that there is no immediate validation when a value other than an alternate method and a Expression Language expression were entered. Is there perhaps another way that you could think of which would allow for immediate validation on the basic HTTP methods?

Thanks for the reply @dan-s1. I can appreciate the challenge on the one hand, given the smaller number of standard HTTP verbs. The problem with the change as implemented is that it could break configurations that are using other verbs, such as TRACE.

There are other possibilities that come to mind based on introducing another property, but InvokeHTTP already has a very large number of properties, so I don't think that is a good solution. I recommend closing this PR for now, and if other ideas come to mind, glad to discuss on the Jira issue.

@dan-s1 dan-s1 closed this Nov 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants