NIFI-15169 Ensure ExecuteSQLRecord routes streaming failures#10584
Closed
takraj wants to merge 2 commits intoapache:mainfrom
Closed
NIFI-15169 Ensure ExecuteSQLRecord routes streaming failures#10584takraj wants to merge 2 commits intoapache:mainfrom
takraj wants to merge 2 commits intoapache:mainfrom
Conversation
* Retain incoming `FlowFile` attributes whenever batching removes the original, so late `ResultSet` errors have context and can be routed to failure. * Recreate the `FlowFile` from those saved attributes, because `commitAsync` forces us to remove the original. * Add a record-oriented streaming failure test that forces a mocked `RecordSetWriter` to throw mid-stream and asserts the reconstructed `FlowFile` still hits `REL_FAILURE` with original attributes.
mark-bathori
reviewed
Dec 3, 2025
Contributor
mark-bathori
left a comment
mark-bathori
left a comment
There was a problem hiding this comment.
Thanks, @takraj, for fixing this issue. The changes overall look good, I have only one minor comment.
| if (fileToProcess != null) { | ||
| // Need to remove the original input file if it exists, | ||
| // but save the attributes to add them to the failure flow file if it is created | ||
| if (fileToProcess != null && retainedFlowFileAttributes == null) { |
Contributor
There was a problem hiding this comment.
I think the retainedFlowFileAttributes == null check is unnecessary. If fileToProcess is not null, we should always store the attributes and remove the FlowFile.
Contributor
Author
There was a problem hiding this comment.
Thank you for pointing this out. I have removed the superfluous condition in: 4d1a81d
mark-bathori
approved these changes
Dec 4, 2025
Contributor
mark-bathori
left a comment
mark-bathori
left a comment
There was a problem hiding this comment.
Thanks @takraj for the adjustment.
LGTM +1
Merging.
mark-bathori
pushed a commit
to mark-bathori/nifi
that referenced
this pull request
Feb 5, 2026
Signed-off-by: Mark Bathori <mbathori@apache.org> This closes apache#10584.
yisun-anetac
pushed a commit
to Eng-Anetac/nifi
that referenced
this pull request
Apr 4, 2026
Signed-off-by: Mark Bathori <mbathori@apache.org> This closes apache#10584.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FlowFileattributes whenever batching removes the original, so lateResultSeterrors have context and can be routed to failure.FlowFilefrom those saved attributes, becausecommitAsyncforces us to remove the original.RecordSetWriterto throw mid-stream and asserts the reconstructedFlowFilestill hitsREL_FAILUREwith original attributes.Summary
NIFI-15169
Tracking
Please complete the following tracking steps prior to pull request creation.
Issue Tracking
Pull Request Tracking
NIFI-00000NIFI-00000Pull Request Formatting
mainbranchVerification
Please indicate the verification steps performed prior to pull request creation.
Build
./mvnw clean install -P contrib-checkLicensing
LICENSEandNOTICEfilesDocumentation