NIFI-15295 Fix unstable TestStandardControllerServiceProvider method#10602
Closed
exceptionfactory wants to merge 1 commit intoapache:mainfrom
Closed
NIFI-15295 Fix unstable TestStandardControllerServiceProvider method#10602exceptionfactory wants to merge 1 commit intoapache:mainfrom
exceptionfactory wants to merge 1 commit intoapache:mainfrom
Conversation
- Adjusted testEnableDisableWithReference method to join and wait for completion of enable and disable Futures
pvillard31
approved these changes
Dec 4, 2025
Contributor
pvillard31
left a comment
pvillard31
left a comment
There was a problem hiding this comment.
LGTM, thanks @exceptionfactory
mark-bathori
pushed a commit
to mark-bathori/nifi
that referenced
this pull request
Feb 5, 2026
- Adjusted testEnableDisableWithReference method to join and wait for completion of enable and disable Futures Signed-off-by: Pierre Villard <pierre.villard.fr@gmail.com> This closes apache#10602.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NIFI-15295 Improves the stability of the
TestStandardControllerServiceProvider.testEnableDisableWithReference()method following recent changes to perform validation on a Controller Service when enabling. Changes include joining on the returnedCompletableFuturefor enable and disable methods before asserting expected status, with the goal of avoiding unexpected states ofENABLINGwhen the actual state is alreadyENABLED.Tracking
Please complete the following tracking steps prior to pull request creation.
Issue Tracking
Pull Request Tracking
NIFI-00000NIFI-00000Pull Request Formatting
mainbranchVerification
Please indicate the verification steps performed prior to pull request creation.
Build
./mvnw clean install -P contrib-checkLicensing
LICENSEandNOTICEfilesDocumentation