NIFI-15296 Fix enabling Controller Services with dependencies#10603
Closed
exceptionfactory wants to merge 1 commit intoapache:mainfrom
Closed
NIFI-15296 Fix enabling Controller Services with dependencies#10603exceptionfactory wants to merge 1 commit intoapache:mainfrom
exceptionfactory wants to merge 1 commit intoapache:mainfrom
Conversation
- Filtered list of required Controller Services based on whether the property descriptor has satisfied dependencies to avoid enabling unnecessary referenced Controller Services - Added unit test with Primary Controller Service referencing Secondary Controller Service depending on specified properties
pvillard31
approved these changes
Dec 6, 2025
Contributor
pvillard31
left a comment
pvillard31
left a comment
There was a problem hiding this comment.
Thanks @exceptionfactory - I tested a few scenarios and everything is working as expected, this is a nice improvement !
mark-bathori
pushed a commit
to mark-bathori/nifi
that referenced
this pull request
Feb 5, 2026
- Filtered list of required Controller Services based on whether the property descriptor has satisfied dependencies to avoid enabling unnecessary referenced Controller Services - Added unit test with Primary Controller Service referencing Secondary Controller Service depending on specified properties Signed-off-by: Pierre Villard <pierre.villard.fr@gmail.com> This closes apache#10603.
yisun-anetac
pushed a commit
to Eng-Anetac/nifi
that referenced
this pull request
Apr 4, 2026
- Filtered list of required Controller Services based on whether the property descriptor has satisfied dependencies to avoid enabling unnecessary referenced Controller Services - Added unit test with Primary Controller Service referencing Secondary Controller Service depending on specified properties Signed-off-by: Pierre Villard <pierre.villard.fr@gmail.com> This closes apache#10603.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NIFI-15296 Corrects framework enabling of referenced Controller Services with unsatisfied property dependencies.
The primary change in
StandardControllerServiceNode.getRequriedControllerServices()now evaluates whether a configured and referenced Controller Service has property dependencies satisfied.Referenced Controller Services that do not depend on other property values remain included in the list of required Controller Services. Referenced Controller Services that depend on other property values, and have those dependencies satisfied also remain included. The method now filters out Controller Services that do not have satisfied dependencies, which avoids enabling unnecessary Controller Services as part of the chain of enabling the parent Controller Service.
The initial implementation of
getRequiredControllerServices()predated the introduction of dependent properties. The need to avoid enabling selected Controller Services is limited to the situation where a Controller Service property depends on the value of another property.A new unit test method exercises the updated behavior, with a
PrimaryServicethat has two properties. ThePrimaryServicehas a required property that references aSecondary Serviceand also has a required property namedSecondary Service Enabledon which theSecondary Serviceproperty depends. The unit sets configures a Controller Service Identifier for theSecondary Servicebut verifies that the service is not enabled, because theSecondary Service Enabledproperty is not configured.Tracking
Please complete the following tracking steps prior to pull request creation.
Issue Tracking
Pull Request Tracking
NIFI-00000NIFI-00000Pull Request Formatting
mainbranchVerification
Please indicate the verification steps performed prior to pull request creation.
Build
./mvnw clean install -P contrib-checkLicensing
LICENSEandNOTICEfilesDocumentation