Skip to content

NIFI-15300 - Fix missing migrateProperties() for Proxy Service configuration#10607

Merged
exceptionfactory merged 2 commits intoapache:mainfrom
pvillard31:NIFI-15300
Dec 6, 2025
Merged

NIFI-15300 - Fix missing migrateProperties() for Proxy Service configuration#10607
exceptionfactory merged 2 commits intoapache:mainfrom
pvillard31:NIFI-15300

Conversation

@pvillard31
Copy link
Copy Markdown
Contributor

Summary

NIFI-15300 - Fix missing migrateProperties() for Proxy Service configuration

Tracking

Please complete the following tracking steps prior to pull request creation.

Issue Tracking

Pull Request Tracking

  • Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-00000
  • Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-00000

Pull Request Formatting

  • Pull Request based on current revision of the main branch
  • Pull Request refers to a feature branch with one commit containing changes

Verification

Please indicate the verification steps performed prior to pull request creation.

Build

  • Build completed using ./mvnw clean install -P contrib-check
    • JDK 21
    • JDK 25

Licensing

  • New dependencies are compatible with the Apache License 2.0 according to the License Policy
  • New dependencies are documented in applicable LICENSE and NOTICE files

Documentation

  • Documentation formatting appears as expected in rendered files

Copy link
Copy Markdown
Contributor

@dan-s1 dan-s1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will keep reviewing I had the comment I left but I also do no see migrations for all the classes which use AzureStorageUtils.PROXY_CONFIGURATION_SERVICE i.e. all

  1. ###AzureBlobStorage_v12
  2. ###AzureDataLakeStorage
  3. ADLSCredentialsControllerService

Also I do not see migrations for

  1. AbstractGCPProcessor
  2. Any class using FTPTransfer.PROXY_CONFIGURATION_SERVICE (FetchFTP, GetFTP, ListFTP, PutFTP)

@Override
public void migrateProperties(PropertyConfiguration config) {
config.renameProperty(AzureStorageUtils.STORAGE_ENDPOINT_SUFFIX_PROPERTY_DESCRIPTOR_NAME, ENDPOINT_SUFFIX.getName());
ProxyServiceMigration.renameProxyConfigurationServiceProperty(config);
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the migration is happening in the parent class, wouldn't it make sense to define the property with value ProxyConfiguration.createProxyConfigPropertyDescriptor(PROXY_SPECS) in this class and have it shared with its children GetAzureQueueStorage_v12 and PutAzureQueueStorage_v12 instead of making this call in both children?

@pvillard31
Copy link
Copy Markdown
Contributor Author

  • AbstractGCPProcessor and all GCP processors - calls ProxyServiceMigration.migrateProxyProperties() which now includes the rename
  • FTP/SFTP Processors (FetchFTP, GetFTP, ListFTP, PutFTP, FetchSFTP, GetSFTP, ListSFTP, PutSFTP, DeleteSFTP) - call FTPTransfer.migrateProxyProperties() → ProxyServiceMigration.migrateProxyProperties()

Copy link
Copy Markdown
Contributor

@exceptionfactory exceptionfactory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing the Proxy Service migration handling across these components @pvillard31, and thanks for the review @dan-s1, the updates look good.

@exceptionfactory exceptionfactory merged commit f918193 into apache:main Dec 6, 2025
7 checks passed
mark-bathori pushed a commit to mark-bathori/nifi that referenced this pull request Feb 5, 2026
…ation (apache#10607)

Signed-off-by: David Handermann <exceptionfactory@apache.org>
yisun-anetac pushed a commit to Eng-Anetac/nifi that referenced this pull request Apr 4, 2026
…ation (apache#10607)

Signed-off-by: David Handermann <exceptionfactory@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants