NIFI-15300 - Fix missing migrateProperties() for Proxy Service configuration#10607
NIFI-15300 - Fix missing migrateProperties() for Proxy Service configuration#10607exceptionfactory merged 2 commits intoapache:mainfrom
Conversation
There was a problem hiding this comment.
I will keep reviewing I had the comment I left but I also do no see migrations for all the classes which use AzureStorageUtils.PROXY_CONFIGURATION_SERVICE i.e. all
- ###AzureBlobStorage_v12
- ###AzureDataLakeStorage
- ADLSCredentialsControllerService
Also I do not see migrations for
- AbstractGCPProcessor
- Any class using FTPTransfer.PROXY_CONFIGURATION_SERVICE (FetchFTP, GetFTP, ListFTP, PutFTP)
| @Override | ||
| public void migrateProperties(PropertyConfiguration config) { | ||
| config.renameProperty(AzureStorageUtils.STORAGE_ENDPOINT_SUFFIX_PROPERTY_DESCRIPTOR_NAME, ENDPOINT_SUFFIX.getName()); | ||
| ProxyServiceMigration.renameProxyConfigurationServiceProperty(config); |
There was a problem hiding this comment.
Since the migration is happening in the parent class, wouldn't it make sense to define the property with value ProxyConfiguration.createProxyConfigPropertyDescriptor(PROXY_SPECS) in this class and have it shared with its children GetAzureQueueStorage_v12 and PutAzureQueueStorage_v12 instead of making this call in both children?
|
exceptionfactory
left a comment
There was a problem hiding this comment.
Thanks for addressing the Proxy Service migration handling across these components @pvillard31, and thanks for the review @dan-s1, the updates look good.
…ation (apache#10607) Signed-off-by: David Handermann <exceptionfactory@apache.org>
…ation (apache#10607) Signed-off-by: David Handermann <exceptionfactory@apache.org>
Summary
NIFI-15300 - Fix missing migrateProperties() for Proxy Service configuration
Tracking
Please complete the following tracking steps prior to pull request creation.
Issue Tracking
Pull Request Tracking
NIFI-00000NIFI-00000Pull Request Formatting
mainbranchVerification
Please indicate the verification steps performed prior to pull request creation.
Build
./mvnw clean install -P contrib-checkLicensing
LICENSEandNOTICEfilesDocumentation