Skip to content

NIFI-15331 Fix Script Engine property name migration from 2.7.0#10634

Merged
dan-s1 merged 1 commit intoapache:mainfrom
exceptionfactory:NIFI-15331
Dec 11, 2025
Merged

NIFI-15331 Fix Script Engine property name migration from 2.7.0#10634
dan-s1 merged 1 commit intoapache:mainfrom
exceptionfactory:NIFI-15331

Conversation

@exceptionfactory
Copy link
Contributor

Summary

NIFI-15331 Corrects property name migration for scripting components when upgrading from NiFi 2.7.0 with a configured value for the Script Engine property.

Changes implemented for NIFI-15317 addressed scenarios when upgrading from NiFi 2.6.0 or earlier, and when upgrading from NiFi 2.7.0 after setting a corrected value, but did not address the scenario where the interim property name remained uncorrected.

Additional updates modify ScriptingComponentHelper.migrateProperties() to check for a configured value of Script Engine and remove the Script Language property. New tests for that method and representative referencing components verify the expected behavior.

Tracking

Please complete the following tracking steps prior to pull request creation.

Issue Tracking

Pull Request Tracking

  • Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-00000
  • Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-00000

Pull Request Formatting

  • Pull Request based on current revision of the main branch
  • Pull Request refers to a feature branch with one commit containing changes

Verification

Please indicate the verification steps performed prior to pull request creation.

Build

  • Build completed using ./mvnw clean install -P contrib-check
    • JDK 21
    • JDK 25

Licensing

  • New dependencies are compatible with the Apache License 2.0 according to the License Policy
  • New dependencies are documented in applicable LICENSE and NOTICE files

Documentation

  • Documentation formatting appears as expected in rendered files

- Adjusted ScriptingComponentHelper.migrateProperties to check for a configured Script Engine value and prefer that value instead of preferring Script Language value
@dan-s1 dan-s1 self-requested a review December 11, 2025 17:56
Copy link
Contributor

@pvillard31 pvillard31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @exceptionfactory - @dan-s1 feel free to merge if you're happy with it

Copy link
Contributor

@dan-s1 dan-s1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM +1. I reviewed the code, built it and it solved the issue I had reported. Thanks @exceptionfactory for the quick fix!

@dan-s1 dan-s1 merged commit c7a16c4 into apache:main Dec 11, 2025
7 checks passed
mark-bathori pushed a commit to mark-bathori/nifi that referenced this pull request Feb 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants