NIFI-15335 Created migration property unit tests for those components in extended bundles nifi-airtable-bundle, nifi-amqp-bundle, nifi-asana-bundle, nifi-asn1-bundle and nifi-aws-bundle which did not have.#10653
Conversation
exceptionfactory
left a comment
There was a problem hiding this comment.
Thanks @dan-s1, just noted a couple minor formatting issues, and recommending avoiding changes to runtime classes for migration tests.
...nifi-asn1-bundle/nifi-asn1-services/src/test/java/org/apache/nifi/jasn1/JASN1ReaderTest.java
Outdated
Show resolved
Hide resolved
...les/nifi-asn1-bundle/nifi-asn1-services/src/main/java/org/apache/nifi/jasn1/JASN1Reader.java
Outdated
Show resolved
Hide resolved
...abstract-processors/src/main/java/org/apache/nifi/processors/aws/s3/AbstractS3Processor.java
Outdated
Show resolved
Hide resolved
exceptionfactory
left a comment
There was a problem hiding this comment.
Thanks @dan-s1, I may have missed some formatting details on the first pass through, but I noted them on this review, and then this should be ready to go.
...s-abstract-processors/src/main/java/org/apache/nifi/processors/aws/AbstractAwsProcessor.java
Outdated
Show resolved
Hide resolved
...les/nifi-asn1-bundle/nifi-asn1-services/src/main/java/org/apache/nifi/jasn1/JASN1Reader.java
Outdated
Show resolved
Hide resolved
|
@exceptionfactory There is a warning regarding merging is blocked as the commits must have verified signatures. I just signed the latest commit but the others I had not. What should I do? Please advise. |
It looks like the earlier commits in the branch don't have signed commits. Feel free to squash the current set of changes into a single signed commit and that should work. |
… in extended bundles nifi-airtable-bundle, nifi-amqp-bundle, nifi-asana-bundle, nifi-asn1-bundle and nifi-aws-bundle which did not have.
exceptionfactory
left a comment
There was a problem hiding this comment.
Thanks for making the adjustments @dan-s1, the latest version looks good. +1 merging
… Asana, ASN.1 and AWS bundles (apache#10653) Signed-off-by: David Handermann <exceptionfactory@apache.org>
Summary
NIFI-15335
Tracking
Please complete the following tracking steps prior to pull request creation.
Issue Tracking
Pull Request Tracking
NIFI-00000NIFI-00000Pull Request Formatting
mainbranchVerification
Please indicate the verification steps performed prior to pull request creation.
Build
./mvnw clean install -P contrib-checkLicensing
LICENSEandNOTICEfilesDocumentation