Skip to content

NIFI-15335 Created migration property unit tests for those components in extended bundles nifi-airtable-bundle, nifi-amqp-bundle, nifi-asana-bundle, nifi-asn1-bundle and nifi-aws-bundle which did not have.#10653

Merged
exceptionfactory merged 1 commit intoapache:mainfrom
dan-s1:NIFI-15335
Dec 23, 2025

Conversation

@dan-s1
Copy link
Contributor

@dan-s1 dan-s1 commented Dec 16, 2025

Summary

NIFI-15335

Tracking

Please complete the following tracking steps prior to pull request creation.

Issue Tracking

Pull Request Tracking

  • Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-00000
  • Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-00000

Pull Request Formatting

  • Pull Request based on current revision of the main branch
  • Pull Request refers to a feature branch with one commit containing changes

Verification

Please indicate the verification steps performed prior to pull request creation.

Build

  • Build completed using ./mvnw clean install -P contrib-check
    • JDK 21
    • JDK 25

Licensing

  • New dependencies are compatible with the Apache License 2.0 according to the License Policy
  • New dependencies are documented in applicable LICENSE and NOTICE files

Documentation

  • Documentation formatting appears as expected in rendered files

Copy link
Contributor

@exceptionfactory exceptionfactory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dan-s1, just noted a couple minor formatting issues, and recommending avoiding changes to runtime classes for migration tests.

Copy link
Contributor

@exceptionfactory exceptionfactory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dan-s1, I may have missed some formatting details on the first pass through, but I noted them on this review, and then this should be ready to go.

@dan-s1
Copy link
Contributor Author

dan-s1 commented Dec 22, 2025

@exceptionfactory There is a warning regarding merging is blocked as the commits must have verified signatures. I just signed the latest commit but the others I had not. What should I do? Please advise.

@exceptionfactory
Copy link
Contributor

@exceptionfactory There is a warning regarding merging is blocked as the commits must have verified signatures. I just signed the latest commit but the others I had not. What should I do? Please advise.

It looks like the earlier commits in the branch don't have signed commits. Feel free to squash the current set of changes into a single signed commit and that should work.

… in extended bundles nifi-airtable-bundle, nifi-amqp-bundle, nifi-asana-bundle, nifi-asn1-bundle and nifi-aws-bundle which did not have.
Copy link
Contributor

@exceptionfactory exceptionfactory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the adjustments @dan-s1, the latest version looks good. +1 merging

@exceptionfactory exceptionfactory merged commit aa8f13e into apache:main Dec 23, 2025
7 checks passed
mark-bathori pushed a commit to mark-bathori/nifi that referenced this pull request Feb 5, 2026
… Asana, ASN.1 and AWS bundles (apache#10653)

Signed-off-by: David Handermann <exceptionfactory@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants