NIFI-15452 - FlowRegistryClient validation not triggered when properties change at runtime#10757
Merged
exceptionfactory merged 1 commit intoapache:mainfrom Jan 12, 2026
Merged
Conversation
…ies change at runtime
kkmurthyt21
reviewed
Jan 10, 2026
| @Override | ||
| public boolean isValidationNecessary() { | ||
| return getValidationStatus() != ValidationStatus.VALID; | ||
| return true; |
There was a problem hiding this comment.
Removed validation check and returning true by Default now?
Contributor
Author
There was a problem hiding this comment.
This is not about returning that validation is true and we don't check anything, this is about saying that we should always check for the component's validity. Similar to parameter providers, registry clients cannot be enabled/disabled so we should always check for the validity.
exceptionfactory
approved these changes
Jan 12, 2026
Contributor
exceptionfactory
left a comment
exceptionfactory
left a comment
There was a problem hiding this comment.
Thanks @pvillard31, looks good, and makes sense given the lifecycle of Flow Registry Clients.
mark-bathori
pushed a commit
to mark-bathori/nifi
that referenced
this pull request
Feb 5, 2026
…idation (apache#10757) Signed-off-by: David Handermann <exceptionfactory@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NIFI-15452 - FlowRegistryClient validation not triggered when properties change at runtime
(the change is consistent with what we already have on parameter providers for example)
Tracking
Please complete the following tracking steps prior to pull request creation.
Issue Tracking
Pull Request Tracking
NIFI-00000NIFI-00000VerifiedstatusPull Request Formatting
mainbranchVerification
Please indicate the verification steps performed prior to pull request creation.
Build
./mvnw clean install -P contrib-checkLicensing
LICENSEandNOTICEfilesDocumentation