NIFI-13987 - Add SSL Context Service in GitHubFlowRegistryClient and GitLabFlowRegistryClient#10788
Merged
exceptionfactory merged 2 commits intoapache:mainfrom Jan 20, 2026
Merged
Conversation
…GitLabFlowRegistryClient
exceptionfactory
requested changes
Jan 20, 2026
Contributor
exceptionfactory
left a comment
exceptionfactory
left a comment
There was a problem hiding this comment.
Thanks for putting this together @pvillard31. Most of the changes look good. I noted one recommendation to use the Java HttpClient instead of OkHttp.
|
|
||
| // Configure OkHttp connector with SSL context if provided | ||
| if (builder.sslContextProvider != null) { | ||
| final OkHttpClient okHttpClient = new OkHttpClient.Builder() |
Contributor
There was a problem hiding this comment.
Instead of using OkHttp, the HttpClientGitHubConnector implementation should avoid the additional dependency on OkHttp
exceptionfactory
approved these changes
Jan 20, 2026
Contributor
exceptionfactory
left a comment
exceptionfactory
left a comment
There was a problem hiding this comment.
Thanks for adjusting the GitHub Connector implementation @pvillard31, the latest version looks good. +1 merging
mark-bathori
pushed a commit
to mark-bathori/nifi
that referenced
this pull request
Feb 5, 2026
…tLabFlowRegistryClient (apache#10788) Signed-off-by: David Handermann <exceptionfactory@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NIFI-13987 - Add SSL Context Service in GitHubFlowRegistryClient and GitLabFlowRegistryClient
Tracking
Please complete the following tracking steps prior to pull request creation.
Issue Tracking
Pull Request Tracking
NIFI-00000NIFI-00000VerifiedstatusPull Request Formatting
mainbranchVerification
Please indicate the verification steps performed prior to pull request creation.
Build
./mvnw clean install -P contrib-checkLicensing
LICENSEandNOTICEfilesDocumentation