NIFI-15549: Adding endpoints for viewing and clearing state for compo…#10855
Merged
rfellows merged 2 commits intoapache:NIFI-15258from Feb 5, 2026
Merged
NIFI-15549: Adding endpoints for viewing and clearing state for compo…#10855rfellows merged 2 commits intoapache:NIFI-15258from
rfellows merged 2 commits intoapache:NIFI-15258from
Conversation
…nents that are managed by a Connector.
rfellows
requested changes
Feb 5, 2026
Comment on lines
2244
to
2247
| serviceFacade.authorizeAccess(lookup -> { | ||
| final Authorizable connector = lookup.getConnector(connectorId); | ||
| connector.authorize(authorizer, RequestAction.WRITE, NiFiUserUtils.getNiFiUser()); | ||
| }); |
Contributor
There was a problem hiding this comment.
This should use withWriteLock pattern that is established in other resources for state-modifying operations
Comment on lines
2353
to
2356
| serviceFacade.authorizeAccess(lookup -> { | ||
| final Authorizable connector = lookup.getConnector(connectorId); | ||
| connector.authorize(authorizer, RequestAction.WRITE, NiFiUserUtils.getNiFiUser()); | ||
| }); |
Contributor
There was a problem hiding this comment.
This should use withWriteLock pattern that is established in other resources for state-modifying operations
Contributor
There was a problem hiding this comment.
The unit tests added in TestConnectorResource.java only test the REST resource layer with mocked serviceFacade calls. There are no integration or unit tests for the actual StandardNiFiServiceFacade implementation methods:
- getConnectorProcessorState
- clearConnectorProcessorState
- getConnectorControllerServiceState
- clearConnectorControllerServiceState
- locateConnectorProcessor
- locateConnectorControllerService
rfellows
approved these changes
Feb 5, 2026
markap14
pushed a commit
that referenced
this pull request
Feb 11, 2026
#10855) * NIFI-15549: Adding endpoints for viewing and clearing state for components that are managed by a Connector. * NIFI-15549: Addressing review feedback.
pvillard31
pushed a commit
to pvillard31/nifi
that referenced
this pull request
Feb 14, 2026
apache#10855) * NIFI-15549: Adding endpoints for viewing and clearing state for components that are managed by a Connector. * NIFI-15549: Addressing review feedback.
pvillard31
pushed a commit
that referenced
this pull request
Feb 14, 2026
#10855) * NIFI-15549: Adding endpoints for viewing and clearing state for components that are managed by a Connector. * NIFI-15549: Addressing review feedback.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…nents that are managed by a Connector.
Summary
NIFI-00000
Tracking
Please complete the following tracking steps prior to pull request creation.
Issue Tracking
Pull Request Tracking
NIFI-00000NIFI-00000VerifiedstatusPull Request Formatting
mainbranchVerification
Please indicate the verification steps performed prior to pull request creation.
Build
./mvnw clean install -P contrib-checkLicensing
LICENSEandNOTICEfilesDocumentation