Skip to content

NIFI-15636 - Fix NPE in StandardFlowComparator when property descriptors are null in compareProperties#10927

Merged
exceptionfactory merged 1 commit intoapache:mainfrom
pvillard31:NIFI-15636
Feb 24, 2026
Merged

NIFI-15636 - Fix NPE in StandardFlowComparator when property descriptors are null in compareProperties#10927
exceptionfactory merged 1 commit intoapache:mainfrom
pvillard31:NIFI-15636

Conversation

@pvillard31
Copy link
Contributor

Summary

NIFI-15636 - Fix NPE in StandardFlowComparator when property descriptors are null in compareProperties

The compare(VersionedFlowRegistryClient) method already wraps its compareProperties call with the existing nullToEmpty() helper, but the same protection is missing from the compare methods for VersionedProcessor, VersionedReportingTask, VersionedFlowAnalysisRule, VersionedParameterProvider, and VersionedControllerService.

Tracking

Please complete the following tracking steps prior to pull request creation.

Issue Tracking

Pull Request Tracking

  • Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-00000
  • Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-00000
  • Pull request contains commits signed with a registered key indicating Verified status

Pull Request Formatting

  • Pull Request based on current revision of the main branch
  • Pull Request refers to a feature branch with one commit containing changes

Verification

Please indicate the verification steps performed prior to pull request creation.

Build

  • Build completed using ./mvnw clean install -P contrib-check
    • JDK 21
    • JDK 25

Licensing

  • New dependencies are compatible with the Apache License 2.0 according to the License Policy
  • New dependencies are documented in applicable LICENSE and NOTICE files

Documentation

  • Documentation formatting appears as expected in rendered files

@pvillard31 pvillard31 added the bug label Feb 23, 2026
Copy link
Contributor

@exceptionfactory exceptionfactory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @pvillard31, although this sounds like it should not happen under most circumstances, the null safety is help and straightforward. +1 merging

@exceptionfactory exceptionfactory merged commit 9ec7561 into apache:main Feb 24, 2026
21 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants