NIFI-7307 Adding support for setting and retrieving Azure Blob Storag…#10939
NIFI-7307 Adding support for setting and retrieving Azure Blob Storag…#10939pkelly-nifi wants to merge 3 commits intoapache:mainfrom
Conversation
pvillard31
left a comment
pvillard31
left a comment
There was a problem hiding this comment.
Left some initial comments. Will be also important to add some test coverage.
...ocessors/src/main/java/org/apache/nifi/processors/azure/storage/PutAzureBlobStorage_v12.java
Outdated
Show resolved
Hide resolved
...ocessors/src/main/java/org/apache/nifi/processors/azure/storage/PutAzureBlobStorage_v12.java
Outdated
Show resolved
Hide resolved
...sors/src/main/java/org/apache/nifi/processors/azure/storage/GetAzureBlobStorageTags_v12.java
Outdated
Show resolved
Hide resolved
| @SeeAlso({ ListAzureBlobStorage_v12.class, FetchAzureBlobStorage_v12.class, PutAzureBlobStorage_v12.class, | ||
| CopyAzureBlobStorage_v12.class, DeleteAzureBlobStorage_v12.class, GetAzureBlobStorageMetadata_v12.class }) | ||
| @CapabilityDescription("Retrieves user metadata and/or tags from the specified blob from Azure Blob Storage. The processor uses Azure Blob Storage client library v12.") | ||
| @InputRequirement(Requirement.INPUT_REQUIRED) |
There was a problem hiding this comment.
write attributes annotation
There was a problem hiding this comment.
Added. Please let me know if you have a better suggestion for annotating these dynamic attributes.
| newAttributes.put(ATTRIBUTE_FORMAT_TAG.formatted(key), value); | ||
| }); | ||
|
|
||
| flowFile = session.putAllAttributes(flowFile, newAttributes); |
There was a problem hiding this comment.
missing provenance events
| }); | ||
|
|
||
| flowFile = session.putAllAttributes(flowFile, newAttributes); | ||
| session.transfer(flowFile, REL_FOUND); |
There was a problem hiding this comment.
missing provenance events
| CopyAzureBlobStorage_v12.class, DeleteAzureBlobStorage_v12.class, GetAzureBlobStorageMetadata_v12.class }) | ||
| @CapabilityDescription("Retrieves user metadata and/or tags from the specified blob from Azure Blob Storage. The processor uses Azure Blob Storage client library v12.") | ||
| @InputRequirement(Requirement.INPUT_REQUIRED) | ||
| public class GetAzureBlobStorageTags_v12 extends AbstractAzureBlobProcessor_v12 { |
There was a problem hiding this comment.
There is a lot of code duplication for those two new processors. Could we have a layer of abstraction to avoid code duplication?
|
Thank you for your review and feedback, @pvillard31. I have made all of the changes you requested and will look into adding tests today. It looks like all of the current Azure blob storage tests only focus on property migration, so it might take me a little time to add for these processors. |
2 participants
…e metadata and tags
Summary
NIFI-7307 Adds support for setting and retrieving Azure Blob Storage object metadata and tags. Modeled after similar functionality which exists for S3.
Tracking
Please complete the following tracking steps prior to pull request creation.
Issue Tracking
Pull Request Tracking
NIFI-00000NIFI-00000VerifiedstatusPull Request Formatting
mainbranchVerification
Please indicate the verification steps performed prior to pull request creation.
Build
./mvnw clean install -P contrib-checkLicensing
LICENSEandNOTICEfilesDocumentation