Skip to content

NIFI-15673 - Add support for Author+Committer with git-based Flow Registry Clients#10972

Open
pvillard31 wants to merge 1 commit intoapache:mainfrom
pvillard31:NIFI-15673
Open

NIFI-15673 - Add support for Author+Committer with git-based Flow Registry Clients#10972
pvillard31 wants to merge 1 commit intoapache:mainfrom
pvillard31:NIFI-15673

Conversation

@pvillard31
Copy link
Contributor

Summary

NIFI-15673 - Add support for Author+Committer with git-based Flow Registry Clients

Right now, in NiFi, when using a git-based Flow Registry Client, all commits are made with the identity that is configured for the authentication of the registry client. It means that if many users are using the same NiFi UI, all commits made by different users will be reported as being made with the same user (likely the service account used in the registry client configuration).

This is not ideal when working with multiple users and trying to distinguish who made the actual commits.

With the git-based implementations, it is possible to make a commit and specify both an author and a committer.

This change is to use the identity of the NiFi User connected in the UI as the author and use the identity configured in the registry client as the committer.

Important notes:

  • the proposed implementation in GitHub is using reflection as a temporary workaround until a submitted improvement is accepted/merged/released (see Add support for specifying Author and Committer (issue #2199) hub4j/github-api#2200)
  • if the NiFi User does not resolve to an email address, the identity won't be resolved on the git provider side and it will just show the author as an unkown user with just the NiFi identity
  • I didn't see an option to do that with Bitbucket Data Center

This has been tested with GitHub, GitLab, Azure DevOps and Bitbucket cloud. See some screenshots below.

A potential follow-up improvement would be to show this information in the UI in the views where we list flow versions.

Screenshots

When my NiFi identity does NOT resolve to a user in the git provider:

GitHub

Screenshot 2026-03-05 at 12 02 32

GitLab

Screenshot 2026-03-05 at 12 02 54

Bitbucket (only the author is shown in the UI - see https://jira.atlassian.com/browse/BCLOUD-13836)

Screenshot 2026-03-05 at 12 03 31

When my NiFi identity does resolve to a user in the git provider:

Screenshot 2026-03-05 at 12 12 38

GitHub

Screenshot 2026-03-05 at 12 12 19

Tracking

Please complete the following tracking steps prior to pull request creation.

Issue Tracking

Pull Request Tracking

  • Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-00000
  • Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-00000
  • Pull request contains commits signed with a registered key indicating Verified status

Pull Request Formatting

  • Pull Request based on current revision of the main branch
  • Pull Request refers to a feature branch with one commit containing changes

Verification

Please indicate the verification steps performed prior to pull request creation.

Build

  • Build completed using ./mvnw clean install -P contrib-check
    • JDK 21
    • JDK 25

Licensing

  • New dependencies are compatible with the Apache License 2.0 according to the License Policy
  • New dependencies are documented in applicable LICENSE and NOTICE files

Documentation

  • Documentation formatting appears as expected in rendered files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant