NIFI-15673 - Add support for Author+Committer with git-based Flow Registry Clients#10972
Open
pvillard31 wants to merge 1 commit intoapache:mainfrom
Open
NIFI-15673 - Add support for Author+Committer with git-based Flow Registry Clients#10972pvillard31 wants to merge 1 commit intoapache:mainfrom
pvillard31 wants to merge 1 commit intoapache:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NIFI-15673 - Add support for Author+Committer with git-based Flow Registry Clients
Right now, in NiFi, when using a git-based Flow Registry Client, all commits are made with the identity that is configured for the authentication of the registry client. It means that if many users are using the same NiFi UI, all commits made by different users will be reported as being made with the same user (likely the service account used in the registry client configuration).
This is not ideal when working with multiple users and trying to distinguish who made the actual commits.
With the git-based implementations, it is possible to make a commit and specify both an author and a committer.
This change is to use the identity of the NiFi User connected in the UI as the author and use the identity configured in the registry client as the committer.
Important notes:
This has been tested with GitHub, GitLab, Azure DevOps and Bitbucket cloud. See some screenshots below.
A potential follow-up improvement would be to show this information in the UI in the views where we list flow versions.
Screenshots
When my NiFi identity does NOT resolve to a user in the git provider:
GitHub
GitLab
Bitbucket (only the author is shown in the UI - see https://jira.atlassian.com/browse/BCLOUD-13836)
When my NiFi identity does resolve to a user in the git provider:
GitHub
Tracking
Please complete the following tracking steps prior to pull request creation.
Issue Tracking
Pull Request Tracking
NIFI-00000NIFI-00000VerifiedstatusPull Request Formatting
mainbranchVerification
Please indicate the verification steps performed prior to pull request creation.
Build
./mvnw clean install -P contrib-checkLicensing
LICENSEandNOTICEfilesDocumentation