NIFI-15709 Close OutputStream when schema retrieval fails in RecordWriter#10997
Merged
pvillard31 merged 1 commit intoapache:mainfrom Mar 12, 2026
Merged
NIFI-15709 Close OutputStream when schema retrieval fails in RecordWriter#10997pvillard31 merged 1 commit intoapache:mainfrom
pvillard31 merged 1 commit intoapache:mainfrom
Conversation
…iter When writerFactory.getSchema() throws an exception, the OutputStream opened by session.write(flowFile) was not being closed before the continue statement. This left the FlowFile in an invalid state, causing IllegalStateException when session.remove() was later called. This fix ensures the OutputStream is properly closed in the error handling path before continuing to the next message.
pvillard31
approved these changes
Mar 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a bug in
RecordWriterwhere an unclosedOutputStreamcausesIllegalStateExceptionwhen processing JMS messages with Record Reader/Writer.Problem
When
writerFactory.getSchema()throws an exception (line 134), theOutputStreamopened bysession.write(flowFile)(line 130) is not closed before thecontinuestatement. This leaves the FlowFile in an invalid state. WhenrecordCount == 0,session.remove(flowFile)fails with:Fix
Close
rawOutin the catch block before continuing to the next message.Testing
JIRA
https://issues.apache.org/jira/browse/NIFI-15709