NIFI-6532 Added documentation to TransformXML to explain the usage of dynamic properties in stylesheets.#10999
Conversation
exceptionfactory
left a comment
There was a problem hiding this comment.
@dan-s1 This looks like some helpful improvements and corrections, but the test failures on Windows are concerning, and appear to point to some issues with the new methods. It may be best to decouple documentation additions from tests changes for clarity of review.
|
@exceptionfactory Its not exactly clear to me what the errors are on the Windows box. The last thing I saw was about a directory not existing which did not relate to my additions. |
Thanks, sounds like it could have been an intermittent issue then. |
exceptionfactory
left a comment
There was a problem hiding this comment.
I recommend decoupling the CapturingLogger change to a separate Jira issue. Adding the new unit tests for TransformXml looks good, but since CapturingLogger is a key part of nifi-mock, it seems a bit too buried given the summary context of this issue focusing on documentation.
|
I understand that, but the fix won't be as apparent since there are no unit tests for |
Yes, that would work. Since the Jira issue, and PR title, focus on documentation, decoupling the testing would be helpful for tracking purposes. |
… dynamic properties in stylesheets.
|
Okay I have reduced this PR to only the addition of the |
exceptionfactory
left a comment
There was a problem hiding this comment.
Thanks for refocusing this PR @dan-s1, looks good! +1 merging
Summary
NIFI-6532
This PR is adds documentation to detail the use of dynamic properties in XSLT style sheets.
Tracking
Please complete the following tracking steps prior to pull request creation.
Issue Tracking
Pull Request Tracking
NIFI-00000NIFI-00000VerifiedstatusPull Request Formatting
mainbranchVerification
Please indicate the verification steps performed prior to pull request creation.
Build
./mvnw clean install -P contrib-checkLicensing
LICENSEandNOTICEfilesDocumentation