Skip to content

NIFI-6532 Added documentation to TransformXML to explain the usage of dynamic properties in stylesheets.#10999

Merged
exceptionfactory merged 1 commit intoapache:mainfrom
dan-s1:NIFI-6532
Mar 13, 2026
Merged

NIFI-6532 Added documentation to TransformXML to explain the usage of dynamic properties in stylesheets.#10999
exceptionfactory merged 1 commit intoapache:mainfrom
dan-s1:NIFI-6532

Conversation

@dan-s1
Copy link
Contributor

@dan-s1 dan-s1 commented Mar 12, 2026

Summary

NIFI-6532
This PR is adds documentation to detail the use of dynamic properties in XSLT style sheets.

Tracking

Please complete the following tracking steps prior to pull request creation.

Issue Tracking

Pull Request Tracking

  • Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-00000
  • Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-00000
  • Pull request contains commits signed with a registered key indicating Verified status

Pull Request Formatting

  • Pull Request based on current revision of the main branch
  • Pull Request refers to a feature branch with one commit containing changes

Verification

Please indicate the verification steps performed prior to pull request creation.

Build

  • Build completed using ./mvnw clean install -P contrib-check
    • JDK 21
    • JDK 25

Licensing

  • New dependencies are compatible with the Apache License 2.0 according to the License Policy
  • New dependencies are documented in applicable LICENSE and NOTICE files

Documentation

  • Documentation formatting appears as expected in rendered files

Copy link
Contributor

@exceptionfactory exceptionfactory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dan-s1 This looks like some helpful improvements and corrections, but the test failures on Windows are concerning, and appear to point to some issues with the new methods. It may be best to decouple documentation additions from tests changes for clarity of review.

@dan-s1
Copy link
Contributor Author

dan-s1 commented Mar 13, 2026

@exceptionfactory Its not exactly clear to me what the errors are on the Windows box. The last thing I saw was about a directory not existing which did not relate to my additions.

@exceptionfactory
Copy link
Contributor

@exceptionfactory Its not exactly clear to me what the errors are on the Windows box. The last thing I saw was about a directory not existing which did not relate to my additions.

Thanks, sounds like it could have been an intermittent issue then.

Copy link
Contributor

@exceptionfactory exceptionfactory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I recommend decoupling the CapturingLogger change to a separate Jira issue. Adding the new unit tests for TransformXml looks good, but since CapturingLogger is a key part of nifi-mock, it seems a bit too buried given the summary context of this issue focusing on documentation.

@dan-s1
Copy link
Contributor Author

dan-s1 commented Mar 13, 2026

I understand that, but the fix won't be as apparent since there are no unit tests for CapturingLogger. It is in this ticket, a concrete instance where the issue crops up as I could not check for ValidationException without the stack trace. Should I perhaps separate the unit tests also and include those as well as the fix for CapturingLogger and keep this PR for the documentation only?

@exceptionfactory
Copy link
Contributor

Should I perhaps separate the unit tests also and include those as well as the fix for CapturingLogger and keep this PR for the documentation only?

Yes, that would work. Since the Jira issue, and PR title, focus on documentation, decoupling the testing would be helpful for tracking purposes.

@dan-s1
Copy link
Contributor Author

dan-s1 commented Mar 13, 2026

Okay I have reduced this PR to only the addition of the additionalDetails.md file and I have created NIFI-15715 to handle the other changes and submitted PR #11008.

Copy link
Contributor

@exceptionfactory exceptionfactory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for refocusing this PR @dan-s1, looks good! +1 merging

@exceptionfactory exceptionfactory merged commit ef1f284 into apache:main Mar 13, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants