Skip to content

NIFI-15741: When synchronizing flow, delegate Connector starts to Flo…#11063

Merged
pvillard31 merged 2 commits intoapache:mainfrom
markap14:NIFI-15741
Mar 30, 2026
Merged

NIFI-15741: When synchronizing flow, delegate Connector starts to Flo…#11063
pvillard31 merged 2 commits intoapache:mainfrom
markap14:NIFI-15741

Conversation

@markap14
Copy link
Copy Markdown
Contributor

…wController first so that they are not started before FlowController has initialized and not at all if autoResumeState=false

Summary

NIFI-00000

Tracking

Please complete the following tracking steps prior to pull request creation.

Issue Tracking

Pull Request Tracking

  • Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-00000
  • Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-00000
  • Pull request contains commits signed with a registered key indicating Verified status

Pull Request Formatting

  • Pull Request based on current revision of the main branch
  • Pull Request refers to a feature branch with one commit containing changes

Verification

Please indicate the verification steps performed prior to pull request creation.

Build

  • Build completed using ./mvnw clean install -P contrib-check
    • JDK 21
    • JDK 25

Licensing

  • New dependencies are compatible with the Apache License 2.0 according to the License Policy
  • New dependencies are documented in applicable LICENSE and NOTICE files

Documentation

  • Documentation formatting appears as expected in rendered files

Copy link
Copy Markdown
Contributor

@kevdoran kevdoran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, thanks for this @markap14. Will merge pending a successful CI build

@pvillard31
Copy link
Copy Markdown
Contributor

Merging is blocked
Commits must have verified signatures.

@kevdoran
Copy link
Copy Markdown
Contributor

@markap14 can you review your commit sigs?

Copy link
Copy Markdown
Contributor

@exceptionfactory exceptionfactory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed the following system test failing across all platforms:

ConnectorAutoResumeIT.testConnectorNotResumedWhenAutoResumeDisabled:74 expected: <STOPPED> but was: <UPDATED>

…wController first so that they are not started before FlowController has initialized and not at all if autoResumeState=false
…e=false, explicitly stop them to ensure that the state transitions from UPDATED to STOPPED.
@pvillard31 pvillard31 merged commit dd7ff5a into apache:main Mar 30, 2026
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants