Skip to content

NIFI-14205 Enhanced the AWS components by listing the AWS Regions in case insensitive alphabetical order.#11066

Merged
pvillard31 merged 2 commits intoapache:mainfrom
dan-s1:NIFI-14205
Mar 30, 2026
Merged

NIFI-14205 Enhanced the AWS components by listing the AWS Regions in case insensitive alphabetical order.#11066
pvillard31 merged 2 commits intoapache:mainfrom
dan-s1:NIFI-14205

Conversation

@dan-s1
Copy link
Copy Markdown
Contributor

@dan-s1 dan-s1 commented Mar 27, 2026

Summary

NIFI-14205
Attached are screenshots of the Region property before the change:

region_before_change

and after the change:

region_after_change

Tracking

Please complete the following tracking steps prior to pull request creation.

Issue Tracking

Pull Request Tracking

  • Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-00000
  • Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-00000
  • Pull request contains commits signed with a registered key indicating Verified status

Pull Request Formatting

  • Pull Request based on current revision of the main branch
  • Pull Request refers to a feature branch with one commit containing changes

Verification

Please indicate the verification steps performed prior to pull request creation.

Build

  • Build completed using ./mvnw clean install -P contrib-check
    • JDK 21
    • JDK 25

Licensing

  • New dependencies are compatible with the Apache License 2.0 according to the License Policy
  • New dependencies are documented in applicable LICENSE and NOTICE files

Documentation

  • Documentation formatting appears as expected in rendered files

void testRegionDisplayNameOrdering() {
final List<AllowableValue> allowableRegionValues = REGION.getAllowableValues();

assertEquals("Africa (Cape Town)", allowableRegionValues.getFirst().getDisplayName());
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree this is unlikely but this test might fail when we upgrade the dependency in AWS SDK and they add a new region. Honestly, I'm fine without a unit test for this change. If you can share a screenshot of the before/after in the UI that's good enough with me.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pvillard31 Should I post the screenshots to this PR or the ticket?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

either is fine with me

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pvillard31 I attached them to the summary and I removed the unit test.

@pvillard31 pvillard31 merged commit 8c34b22 into apache:main Mar 30, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants