NIFI-15775 Refactor Snowflake Snowpipe Ingest without SDK#11090
Merged
pvillard31 merged 3 commits intoapache:mainfrom Apr 2, 2026
Merged
NIFI-15775 Refactor Snowflake Snowpipe Ingest without SDK#11090pvillard31 merged 3 commits intoapache:mainfrom
pvillard31 merged 3 commits intoapache:mainfrom
Conversation
- Removed snowflake-ingest-sdk dependency - Refactored SnowflakeIngestManagerProviderService interface with ingest methods - Adjusted Snowflake Processors to use new methods - Added SnowpipeIngestClient implementing Snowpipe REST API methods
pvillard31
reviewed
Apr 2, 2026
...in/java/org/apache/nifi/snowflake/service/StandardSnowflakeIngestManagerProviderService.java
Outdated
Show resolved
Hide resolved
pvillard31
reviewed
Apr 2, 2026
...snowflake-services/src/main/java/org/apache/nifi/snowflake/service/SnowpipeIngestClient.java
Show resolved
Hide resolved
...ke-services/src/main/java/org/apache/nifi/snowflake/service/RSAKeyAuthorizationProvider.java
Show resolved
Hide resolved
...snowflake-services/src/main/java/org/apache/nifi/snowflake/service/SnowpipeIngestClient.java
Outdated
Show resolved
Hide resolved
- Removed informational log for null SnowpipeIngestClient
Contributor
Author
|
Thanks for the review @pvillard31, I pushed an update to address the initial feedback. |
pvillard31
approved these changes
Apr 2, 2026
Contributor
pvillard31
left a comment
pvillard31
left a comment
There was a problem hiding this comment.
Thanks @exceptionfactory - LGTM, merging
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NIFI-15775 Refactors existing Snowflake Snowpipe Ingest components to remove the dependency on the snowflake-ingest-sdk, implementing direct integration with the Snowpipe REST API using the Java HttpClient.
With planned future deprecation of Snowpipe Streaming Classic Architecture, removal of the
snowflake-ingest-sdkavoids future maintenance issues and provides a clear scope of integration using Snowflake Snowpipe loading from Stages.The refactored implementation keeps the existing
SnowflakeIngestManagerProviderServiceController Service interface and implementation, avoiding the need for property migration. Changes include removing existing interface methods and adding new methods that follow the pattern of the Snowpipe REST API insertFiles and insertReport methods, preserving existing functionality in theStartSnowflakeIngestandGetSnowflakeIngestStatusProcessors.New implementation classes include the
SnowflakeIngestClientto implement HTTP methods, and an Authorization Provider responsible for creating and signing JSON Web Tokens using an RSA Private Key. New unit tests exercise these HTTP requests using the OkHttp MockWebServer.Tracking
Please complete the following tracking steps prior to pull request creation.
Issue Tracking
Pull Request Tracking
NIFI-00000NIFI-00000VerifiedstatusPull Request Formatting
mainbranchVerification
Please indicate the verification steps performed prior to pull request creation.
Build
./mvnw clean install -P contrib-checkLicensing
LICENSEandNOTICEfilesDocumentation