Skip to content

NIFI-15790 - Batch secret resolution in StandardConnectorConfigurationContext#11098

Open
pvillard31 wants to merge 2 commits intoapache:mainfrom
pvillard31:NIFI-15790
Open

NIFI-15790 - Batch secret resolution in StandardConnectorConfigurationContext#11098
pvillard31 wants to merge 2 commits intoapache:mainfrom
pvillard31:NIFI-15790

Conversation

@pvillard31
Copy link
Copy Markdown
Contributor

Summary

NIFI-15790 - Batch secret resolution in StandardConnectorConfigurationContext

Tracking

Please complete the following tracking steps prior to pull request creation.

Issue Tracking

Pull Request Tracking

  • Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-00000
  • Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-00000
  • Pull request contains commits signed with a registered key indicating Verified status

Pull Request Formatting

  • Pull Request based on current revision of the main branch
  • Pull Request refers to a feature branch with one commit containing changes

Verification

Please indicate the verification steps performed prior to pull request creation.

Build

  • Build completed using ./mvnw clean install -P contrib-check
    • JDK 21
    • JDK 25

Licensing

  • New dependencies are compatible with the Apache License 2.0 according to the License Policy
  • New dependencies are documented in applicable LICENSE and NOTICE files

Documentation

  • Documentation formatting appears as expected in rendered files

Copy link
Copy Markdown
Contributor

@exceptionfactory exceptionfactory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this improvement @pvillard31. The functional changes look good, but the test methods contain a number of repeated string literals. It looks like a number of the SecretReference instances could be declared once and reused, along with property names and values used in assertions.

@pvillard31
Copy link
Copy Markdown
Contributor Author

Thanks @exceptionfactory - pushed a commit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants