NIFI-15790 - Batch secret resolution in StandardConnectorConfigurationContext#11098
Open
pvillard31 wants to merge 2 commits intoapache:mainfrom
Open
NIFI-15790 - Batch secret resolution in StandardConnectorConfigurationContext#11098pvillard31 wants to merge 2 commits intoapache:mainfrom
pvillard31 wants to merge 2 commits intoapache:mainfrom
Conversation
exceptionfactory
requested changes
Apr 6, 2026
Contributor
exceptionfactory
left a comment
There was a problem hiding this comment.
Thanks for working on this improvement @pvillard31. The functional changes look good, but the test methods contain a number of repeated string literals. It looks like a number of the SecretReference instances could be declared once and reused, along with property names and values used in assertions.
Contributor
Author
|
Thanks @exceptionfactory - pushed a commit |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NIFI-15790 - Batch secret resolution in StandardConnectorConfigurationContext
Tracking
Please complete the following tracking steps prior to pull request creation.
Issue Tracking
Pull Request Tracking
NIFI-00000NIFI-00000VerifiedstatusPull Request Formatting
mainbranchVerification
Please indicate the verification steps performed prior to pull request creation.
Build
./mvnw clean install -P contrib-checkLicensing
LICENSEandNOTICEfilesDocumentation