Merged
Conversation
mcgilman
requested changes
Apr 7, 2026
...nd/apps/nifi/src/app/pages/connectors/state/connectors-listing/connectors-listing.effects.ts
Outdated
Show resolved
Hide resolved
...nd/apps/nifi/src/app/pages/connectors/state/connectors-listing/connectors-listing.reducer.ts
Outdated
Show resolved
Hide resolved
nifi-frontend/src/main/frontend/apps/nifi/src/app/pages/connectors/service/connector.service.ts
Outdated
Show resolved
Hide resolved
nifi-frontend/src/main/frontend/apps/nifi/src/app/pages/connectors/service/connector.service.ts
Outdated
Show resolved
Hide resolved
...end/apps/nifi/src/app/pages/connectors/state/purge-connector/purge-connector.effects.spec.ts
Outdated
Show resolved
Hide resolved
...ps/nifi/src/app/pages/connectors/state/connectors-listing/connectors-listing.effects.spec.ts
Outdated
Show resolved
Hide resolved
...ps/nifi/src/app/pages/connectors/state/connectors-listing/connectors-listing.effects.spec.ts
Outdated
Show resolved
Hide resolved
.../frontend/apps/nifi/src/app/pages/connectors/ui/connector-table/connector-table.component.ts
Outdated
Show resolved
Hide resolved
...frontend/apps/nifi/src/app/pages/connectors/state/purge-connector/purge-connector.effects.ts
Show resolved
Hide resolved
mcgilman
reviewed
Apr 7, 2026
...nd/apps/nifi/src/app/pages/connectors/state/connectors-listing/connectors-listing.effects.ts
Outdated
Show resolved
Hide resolved
mcgilman
requested changes
Apr 8, 2026
Contributor
There was a problem hiding this comment.
Thanks for the updates @rfellows! Noted a couple more things.
And I think this [1] was missed above.
[1] #11112 (comment)
nifi-frontend/src/main/frontend/apps/nifi/src/app/state/shared/index.ts
Outdated
Show resolved
Hide resolved
...tend/apps/nifi/src/app/pages/connectors/ui/connector-table/connector-table.component.spec.ts
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NIFI-15793 - Connector listing
Summary
This change adds a Connectors listing experience to the NiFi frontend: a lazy-loaded feature with NgRx-backed state, REST integration for connector lifecycle operations, and a Material table UI with sorting, selection, validation feedback, and contextual actions. The feature is gated at build time via
environment.enableConnectorsso it can be compiled in for development while remaining off in production until the project is ready to expose it broadly.In scope
connectorsPermissions.canReadis satisfied; links for Manage Access Policies and View Documentation where applicable.libs/shared/with unit tests.data-qaattributes on connector templates for stable test targeting (scoped to this feature).Not in scope
The following are intentionally not implemented in this PR. Placeholders (e.g. TODOs surfaced via alert dialogs) exist where a future screen would plug in:
These are expected in follow-up work under separate changes.
What changed (high level)
libs/shared/ConnectorEntity, components, actions, state, bundle, etc.); helpers (canReadConnector,canModifyConnector,canOperateConnector,getConnectorAction,isConnectorActionAllowed,getConnectorActionDisabledReason); unit tests for permission utilities.apps/nifi-- connectors featureCanMatchFnguard (connectorsFeatureGuard) tied toenableConnectors;ConnectorService(CRUD, run status, rename, drain, cancel drain, discard working config, purge); NgRx slicesconnectors-listingandpurge-connector; UI:ConnectorsListing,ConnectorTable,CreateConnector,RenameConnectorDialog; eight spec files;data-qahooks.enableConnectors: truein development,falsein production.loadExtensionTypesForConnectorsand related wiring; error context keysCONNECTORS,CONNECTOR_RENAME_DIALOG.Design notes
environment.enableConnectorsso shipping the code does not imply enabling the UI in all environments.CreateConnectorconsumes NgRx selectors instead ofMAT_DIALOG_DATAso dialog behavior stays aligned with global store state.Testing
data-qaattributes support automated or manual targeting of key connector UI elements.