Skip to content

NIFI-13591 Added support for multiline JSON in JSLTTransformJSON.#11141

Merged
exceptionfactory merged 4 commits intoapache:mainfrom
dan-s1:NIFI-13591
Apr 21, 2026
Merged

NIFI-13591 Added support for multiline JSON in JSLTTransformJSON.#11141
exceptionfactory merged 4 commits intoapache:mainfrom
dan-s1:NIFI-13591

Conversation

@dan-s1
Copy link
Copy Markdown
Contributor

@dan-s1 dan-s1 commented Apr 14, 2026

Summary

NIFI-13591

Tracking

Please complete the following tracking steps prior to pull request creation.

Issue Tracking

Pull Request Tracking

  • Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-00000
  • Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-00000
  • Pull request contains commits signed with a registered key indicating Verified status

Pull Request Formatting

  • Pull Request based on current revision of the main branch
  • Pull Request refers to a feature branch with one commit containing changes

Verification

Please indicate the verification steps performed prior to pull request creation.

Build

  • Build completed using ./mvnw clean install -P contrib-check
    • JDK 21
    • JDK 25

Licensing

  • New dependencies are compatible with the Apache License 2.0 according to the License Policy
  • New dependencies are documented in applicable LICENSE and NOTICE files

Documentation

  • Documentation formatting appears as expected in rendered files

Copy link
Copy Markdown
Contributor

@exceptionfactory exceptionfactory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On initial review, I'm concerned about the Multiline Transformation Strategy property, as it makes it more difficult to reason over the Processor configuration in general. I don't think the additional property is necessary, and instead, selecting JSON Lines as the format would effectively handle each object.

@dan-s1
Copy link
Copy Markdown
Contributor Author

dan-s1 commented Apr 14, 2026

I added the Multiline Transformation Strategy because I was under the impression we had to support the same options for each JSON line as we do when the JSON is in one FlowFile which was was operating on the whole JSON object or each individual object if the JSON line contains an array. If that is not the case, I have no problem removing it.

@exceptionfactory
Copy link
Copy Markdown
Contributor

I added the Multiline Transformation Strategy because I was under the impression we had to support the same options for each JSON line as we do when the JSON is in one FlowFile which was was operating on the whole JSON object or each individual object if the JSON line contains an array. If that is not the case, I have no problem removing it.

Thanks for clarifying, I don't think it is necessary when JSON Lines is selected.

@dan-s1
Copy link
Copy Markdown
Contributor Author

dan-s1 commented Apr 14, 2026

I have removed the use of the Multiline Transformation Strategy

Copy link
Copy Markdown
Contributor

@exceptionfactory exceptionfactory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dan-s1, the latest version looks good. +1 merging

@exceptionfactory exceptionfactory merged commit 14a7944 into apache:main Apr 21, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants