NIFI-15840 Added rollback in ExecuteGroovyScript to allow script access to FlowFile.#11155
Merged
Conversation
pvillard31
requested changes
Apr 16, 2026
Contributor
pvillard31
left a comment
There was a problem hiding this comment.
I do not believe this is correct/enough. Consider this test where it fails before we do the get in the script:
@Test
void testTransferToFailureStrategyWhereScriptFailsBeforeGet() {
runner.setProperty(ExecuteGroovyScript.SCRIPT_BODY, """
throw new RuntimeException("fail before get")
""");
runner.setProperty(ExecuteGroovyScript.FAIL_STRATEGY, ExecuteGroovyScript.TRANSFER_TO_FAILURE);
runner.assertValid();
runner.enqueue("test content".getBytes(StandardCharsets.UTF_8));
runner.run();
runner.assertAllFlowFilesTransferred(ExecuteGroovyScript.REL_FAILURE, 1);
}…a scenario where it may not have been called in the Groovy script.
pvillard31
approved these changes
Apr 16, 2026
Contributor
pvillard31
left a comment
There was a problem hiding this comment.
Latest LGTM, thanks @dan-s1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NIFI-15840
This PR fixes the bug in
ExecuteGroovyScriptso it should not fail with "Failure Strategy = transfer to failure" when there is a Groovy script that accesses a FlowFile.In addition to this fix, this PR resolved some of the Intellij warnings.
Tracking
Please complete the following tracking steps prior to pull request creation.
Issue Tracking
Pull Request Tracking
NIFI-00000NIFI-00000VerifiedstatusPull Request Formatting
mainbranchVerification
Please indicate the verification steps performed prior to pull request creation.
Build
./mvnw clean install -P contrib-checkLicensing
LICENSEandNOTICEfilesDocumentation