NIFI-15820: Adding an expandable side panel with a Connector info car…#11160
Merged
Conversation
Contributor
|
Reviewing... |
rfellows
requested changes
Apr 22, 2026
Comment on lines
+18
to
+27
| context-error-banner.canvas-error-banner { | ||
| ::ng-deep .banner-container { | ||
| background-color: var(--mat-sys-surface-container); | ||
| border: 1px solid var(--mat-sys-outline-variant); | ||
| border-radius: 4px; | ||
| box-shadow: 0 1px 6px rgba(0, 0, 0, 0.25); | ||
| color: var(--mat-sys-on-surface); | ||
| margin-bottom: 0; | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
This file isn't leveraged/referenced in the @Component ts file and it duplicates the same styles as in _connector-canvas.component-theme.scss... can we just delete this file since it seems to be unsed?
Comment on lines
+119
to
+133
| canDrain(): boolean { | ||
| const entity = this.connectorEntity(); | ||
| if (!entity) { | ||
| return false; | ||
| } | ||
| return canOperateConnector(entity) && isConnectorActionAllowed(entity, 'DRAIN_FLOWFILES'); | ||
| } | ||
|
|
||
| canCancelDrain(): boolean { | ||
| const entity = this.connectorEntity(); | ||
| if (!entity) { | ||
| return false; | ||
| } | ||
| return canOperateConnector(entity) && isConnectorActionAllowed(entity, 'CANCEL_DRAIN_FLOWFILES'); | ||
| } |
Contributor
There was a problem hiding this comment.
These 2 canXXX methods differ in pattern to the others in this file in that these don't consider the this.entitySaving(). They are more similar to the showXXX methods. I see the entitySaving is instead used on the DOM elements to control disabled state. Maybe tighten up the pattern? I think we are getting what the desired effect is, but the logic isn't consistent.
…d to the Connector canvas.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…d to the Connector canvas.
Summary
Introduces an expandable side panel on the connector canvas that surfaces a
Connector Infocontrol with inline connector management. The side panel uses amat-sidenavinside/disableClosemode, toggled from the header bar, with its open/closed preference persisted via theStorageservice so the layout is remembered across sessions.The new
connector-info-controlcard displays connector state and queued-data metrics, and exposes action buttons for:RUNNINGandSTOPPED.Buttons are kept rendered and toggled via
disabledstate (rather than unmounted) while actions are in-flight to avoid the info panel briefly shrinking to a single row and causing a flicker. Start/Stop are rendered as icon buttons; drain controls usemat-stroked-button; all row-one actions are left-aligned.A new
connector-detail-headershared component provides the name/type/state header and is reused inside the info control.Connector-scoped error banner
To keep API failures from the info card visible (and not silently dropped), a
CONNECTOR_CANVASErrorContextKeywas added and a<context-error-banner>is mounted as a floating overlay over the reusable canvas. A new effect clears priorCONNECTOR_CANVASbanner errors on each action dispatch so stale errors do not leak between operations or across pages. Banner chrome (background, outline, border-radius, shadow) is applied via a new_connector-canvas.component-theme.scsspartial included fromstyles.scss, avoiding::ng-deepwhile participating in light/dark theming.Changes
connector-canvas-entityfeature slice (actions,reducer,effects) handling load, start, stop, drain, cancel-drain, and a unifiedconnectorActionApiErroraction routed to the new canvas banner context.connector-canvas.componentmounts the sidenav, graph controls, and floating error banner.connector-graph-controls.componenthosts the collapsible panel content.connector-info-control.componentrenders the connector detail header, metrics, and actions.connector-detail-header.componentadded underlibs/sharedfor reuse.styles.scssfor both light and dark themes.CONNECTOR_CANVASadded toErrorContextKey.