Skip to content

NIFI-15910 Improve Connector Secret verification#11210

Open
kevdoran wants to merge 1 commit intoapache:mainfrom
kevdoran:NIFI-15910-connector-secret-validation
Open

NIFI-15910 Improve Connector Secret verification#11210
kevdoran wants to merge 1 commit intoapache:mainfrom
kevdoran:NIFI-15910-connector-secret-validation

Conversation

@kevdoran
Copy link
Copy Markdown
Contributor

@kevdoran kevdoran commented May 5, 2026

Summary

NIFI-15910

When a connector configuration contains a SECRET_REFERENCE whose fields (fullyQualifiedSecretName, secretName) are unpopulated — either because the property is gated by another property whose dependency isn't satisfied, or because it's a placeholder default emitted by an external ConnectorConfigurationProviderStandardConnectorNode is eagerly resolving it against the SecretsManager and surfacing Property Validation - Secret Reference: The referenced secret [null] could not be found.

This change makes StandardConnectorNode.resolvePropertyReferences (and the matching validatePropertyReferences step traversal) skip secret resolution for two cases:

  1. Properties whose ConnectorPropertyDependency isn't satisfied — using the same algorithm as AbstractConnector.isDependencySatisfied()
  2. Structurally-empty SECRET_REFERENCE values where neither FQN nor secret name is populated. Empty stubs are treated as unset, so the connector's own required-property check produces the actionable is required message.

Tracking

Please complete the following tracking steps prior to pull request creation.

Issue Tracking

Pull Request Tracking

  • Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-00000
  • Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-00000
  • Pull request contains commits signed with a registered key indicating Verified status

Pull Request Formatting

  • Pull Request based on current revision of the main branch
  • Pull Request refers to a feature branch with one commit containing changes

Verification

Please indicate the verification steps performed prior to pull request creation.

Build

  • Build completed using ./mvnw clean install -P contrib-check
    • JDK 21
    • JDK 25

Licensing

  • New dependencies are compatible with the Apache License 2.0 according to the License Policy
  • New dependencies are documented in applicable LICENSE and NOTICE files

Documentation

  • Documentation formatting appears as expected in rendered files

@kevdoran kevdoran requested review from markap14 and mcgilman May 5, 2026 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant