NIFI-15948 Switch HashiCorp Vault Client Service to SSLContextProvider#11257
Merged
Conversation
pvillard31
approved these changes
May 16, 2026
Contributor
pvillard31
left a comment
There was a problem hiding this comment.
Thanks @exceptionfactory
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NIFI-15948 Refactors the
StandardHashiCorpVaultClientServiceand supporting components to the useSSLContextProviderController Service interface instead of theSSLContextServicefor TLS communication.This refactor follows the pattern of similar adjustments to
SSL Context Serviceproperties across extension components and uses the more genericSSLContextProvider.createContext()method instead of passing individual keystore and truststore properties.For the HashiCorp Vault Client Service, changes include passing a property named
javax.net.ssl.SSLContext, containing the created instance of theSSLContextobject from the provider. Within the receivingStandardHashiCorpVaultCommunicationService, the constructor checks for the presence of theSSLContextproperty and builds the required JDKHttpClientand request factory. In absence of theSSLContextproperty, the constructor retains current behavior, supporting existing configurations that provide Vault SSL properties through external file configuration.Tracking
Please complete the following tracking steps prior to pull request creation.
Issue Tracking
Pull Request Tracking
NIFI-00000NIFI-00000VerifiedstatusPull Request Formatting
mainbranchVerification
Please indicate the verification steps performed prior to pull request creation.
Build
./mvnw clean install -P contrib-checkLicensing
LICENSEandNOTICEfilesDocumentation