Skip to content

NIFI-2861 ControlRate should accept more than one flow file per execution (0.x)#1128

Closed
jskora wants to merge 3 commits intoapache:0.xfrom
jskora:NIFI-2861-0.x
Closed

NIFI-2861 ControlRate should accept more than one flow file per execution (0.x)#1128
jskora wants to merge 3 commits intoapache:0.xfrom
jskora:NIFI-2861-0.x

Conversation

@jskora
Copy link
Contributor

@jskora jskora commented Oct 13, 2016

Thank you for submitting a contribution to Apache NiFi.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message?
  • Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
  • Has your PR been rebased against the latest commit within the target branch (typically master)?
  • Is your initial contribution a single, squashed commit?

For code changes:

  • Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
  • Have you written or updated unit tests to verify your changes?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
  • If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
  • If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.

  • Support multiple files per onTrigger call. (0.x branch)

jskora and others added 3 commits October 13, 2016 02:19
…tion

* Support multiple files per onTrigger call. (0.x branch)
…ged variables to ints from String and AtomicLong. Add unit tests to confirm function of default and configured batch size values.
@mosermw
Copy link
Member

mosermw commented Jan 12, 2017

reviewing

@mosermw
Copy link
Member

mosermw commented Jan 12, 2017

benchmarked ControlRate before patch and after the patch, ControlRate could handle a lot more small files. +1 will merge.

asfgit pushed a commit that referenced this pull request Jan 12, 2017
…tion

Signed-off-by: Mike Moser <mosermw@apache.org>

This closes #1128
@jskora
Copy link
Contributor Author

jskora commented Jan 17, 2017

Closing per commit a3d95dc by @mosermw .

@jskora jskora closed this Jan 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants