NIFI-2819: Added support for Expression Language in ModifyBytes#1130
Closed
mattyb149 wants to merge 1 commit intoapache:masterfrom
Closed
NIFI-2819: Added support for Expression Language in ModifyBytes#1130mattyb149 wants to merge 1 commit intoapache:masterfrom
mattyb149 wants to merge 1 commit intoapache:masterfrom
Conversation
mattyb149
changed the title
olegz
reviewed
Oct 14, 2016
| .expressionLanguageSupported(true) | ||
| .build(); | ||
| public static final PropertyDescriptor END_OFFSET = new PropertyDescriptor.Builder() | ||
| .name("End Offset") |
Contributor
There was a problem hiding this comment.
When I saw end-offset i got confused since the next offset is the end offset, but description states its Number of bytes removed at the end of the file. This means it's not an offset at all.
I know this is not part of the immediate issue, but at least consider raising an improvement JIRA where this could be fixed. Obviously we can't change the name, so we'll keep it, but we can add displayProperty(..)
Contributor
Author
There was a problem hiding this comment.
Works for me, do you want to write the improvement Jira or should I? Is this PR good to go otherwise?
Contributor
There was a problem hiding this comment.
@mattyb149 yes it's +1 here. And yes please raise the improvement JIRA.
I'll merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.