Skip to content

NIFI-3008 Enabled expression language on BASE_DIRECTORY and FILENAME …#1190

Closed
jtstorck wants to merge 1 commit intoapache:masterfrom
jtstorck:NIFI-3008
Closed

NIFI-3008 Enabled expression language on BASE_DIRECTORY and FILENAME …#1190
jtstorck wants to merge 1 commit intoapache:masterfrom
jtstorck:NIFI-3008

Conversation

@jtstorck
Copy link
Contributor

@jtstorck jtstorck commented Nov 9, 2016

…properties in TailFile

Thank you for submitting a contribution to Apache NiFi.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message?

  • Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically master)?

  • Is your initial contribution a single, squashed commit?

For code changes:

  • Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
  • Have you written or updated unit tests to verify your changes?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
  • If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
  • If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.

runner.run(1);
runner.assertAllFlowFilesTransferred(TailFile.REL_SUCCESS, 0);

otherRaf.write("hi\n".getBytes());
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to ensure we don't have weird errors on Windows-based environments consider specifying:

"hi\n".getBytes(StandardCharsets.UTF_8);

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can make that change, but being that it's just a test for reading from the file and the test does not care about the actual output or verify the data read from the file (its just to get TailFile to read some data from the file to show that the processor is resolving the EL) is it really necessary?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, i see, then I agree, that's ok. Will merge

@asfgit asfgit closed this in cc2fbca Nov 9, 2016
@jtstorck jtstorck deleted the NIFI-3008 branch November 14, 2016 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants