NIFI-3008 Enabled expression language on BASE_DIRECTORY and FILENAME …#1190
Closed
jtstorck wants to merge 1 commit intoapache:masterfrom
Closed
NIFI-3008 Enabled expression language on BASE_DIRECTORY and FILENAME …#1190jtstorck wants to merge 1 commit intoapache:masterfrom
jtstorck wants to merge 1 commit intoapache:masterfrom
Conversation
…properties in TailFile
olegz
reviewed
Nov 9, 2016
| runner.run(1); | ||
| runner.assertAllFlowFilesTransferred(TailFile.REL_SUCCESS, 0); | ||
|
|
||
| otherRaf.write("hi\n".getBytes()); |
Contributor
There was a problem hiding this comment.
Just to ensure we don't have weird errors on Windows-based environments consider specifying:
"hi\n".getBytes(StandardCharsets.UTF_8);
Contributor
Author
There was a problem hiding this comment.
I can make that change, but being that it's just a test for reading from the file and the test does not care about the actual output or verify the data read from the file (its just to get TailFile to read some data from the file to show that the processor is resolving the EL) is it really necessary?
Contributor
There was a problem hiding this comment.
Oh, i see, then I agree, that's ok. Will merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…properties in TailFile
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
Has your PR been rebased against the latest commit within the target branch (typically master)?
Is your initial contribution a single, squashed commit?
For code changes:
For documentation related changes:
Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.