NIFI-3024 - Encrypt-toolkit flow.xml.gz support#1221
Closed
brosander wants to merge 1 commit intoapache:masterfrom
Closed
NIFI-3024 - Encrypt-toolkit flow.xml.gz support#1221brosander wants to merge 1 commit intoapache:masterfrom
brosander wants to merge 1 commit intoapache:masterfrom
Conversation
db72bda to
04d6713
Compare
04d6713 to
ca14390
Compare
Contributor
|
@brosander and I discussed this today and there are a couple small edge cases outstanding. As he will be away from his computer for a few days, I am taking over and will have an updated PR (may need to open a new one as I cannot push to his branch) tomorrow. Will update/close here and link to the new one then. |
Contributor
|
@brosander not sure if you noticed there is a merge conflict that needs to be addressed |
Contributor
|
@olegz I think @alopresto is taking over this PR and may create a new one, per his comment |
Contributor
|
I have created PR 1261 to implement this. Recommend this PR be closed. |
Contributor
Author
|
closing in favor of #1261 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
Has your PR been rebased against the latest commit within the target branch (typically master)?
Is your initial contribution a single, squashed commit?
For code changes:
For documentation related changes:
Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.